Move some repository-related configuration options

[Ryan J Ollos]

It might make sense to move the following configuration options:

• [trac] repository_type → [versioncontrol] default_repository_type
• [trac] authz_file → [svn] authz_file
• [trac] authz_module_name → [svn] authz_module_name

This was previously discussed starting in comment:1:ticket:11703.

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t11849.

[Ryan J Ollos]

Committed to trunk in [13846:13847].

[Christian Boos]

Just got hit by this on one system…

After an upgrade, I ended up with:

[versioncontrol]
default_repository_type = 

and the corresponding "'' version control system not supported" error, with no access to any svn repositories possible.

I think that as we used to have svn as an implicit default, my config.get('trac', 'repository_type') was ''… Now if we're going to write that unconditionally, we end up with the above excert in the trac.ini, and the default from the option doesn't kick in.

So maybe we can only write that entry if it has an non-empty value?

[Ryan J Ollos]

Replying to cboos:

So maybe we can only write that entry if it has an non-empty value?

I discovered similar behavior when working on db41.py​. Another option would be to just put the default value in db39.py​: config.get('trac', 'repository_type', 'svn').

[Ryan J Ollos]

Issue from comment:6 fixed in [14152].

[Ryan J Ollos]

Tests added in r14152 weren't being executed when upgrade package tests executed. Fixed in [14862:14863].

[Jun Omae]

I think we could use EnvironmentStub.reset_db_and_disk instead of env.shutdown in [14863].

trac/upgrades/tests/db39.py

@@ -38 +38 @@
         RepositoryManager(self.env)
 
     def tearDown(self):
-        self.env.shutdown()
-        shutil.rmtree(self.env.path)
+        self.env.reset_db_and_disk()
 
     def test_saves_backup(self):
         """Backup file is saved during upgrade."""

[Ryan J Ollos]

Thanks, fixed in [14872].

[Ryan J Ollos]

Edited TracRepositoryAdmin@49.