Edgewall Software
Modify ↓

Opened 10 years ago

Closed 10 years ago

Last modified 7 years ago

#11839 closed enhancement (fixed)

Allow groups to be specified in the set_owner workflow attribute

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.1.3
Component: ticket system Version:
Severity: normal Keywords: workflow
Cc: Branch:
Release Notes:

Groups and permissions can be specified in the comma-separated list of the set_owner workflow attribute.

API Changes:

The PermissionSystem method get_groups_dict returns a dictionary of groups and group members. The method get_users_dict returns a dictionary of users and user permissions.

Internal Changes:

Description

Discussed in ​trac-users:a_Il7M-NP1M/DK7ygmywZv0J, it would be useful if groups could be specified in the set_owner workflow attribute, populating the field with all members of the specified groups.

Attachments (0)

Change History (11)

comment:1 by Ryan J Ollos, 10 years ago

Proposed changes in log:rjollos.git:t11839, but tests still need to be added.

Last edited 10 years ago by Ryan J Ollos (previous) (diff)

comment:2 by Ryan J Ollos, 10 years ago

This change will obsolete the ​th:GroupingAssignToPlugin.

comment:3 by Ryan J Ollos, 10 years ago

​gmessage:trac-users:a_Il7M-NP1M/7yGj6xc2OFUJ suggests allowing a permission to be defined in the set_owner field. This might seem a bit odd, but the idea of populating the list with all users that have a permission seems logical, especially in the case that a custom permission is defined via ExtraPermissionsProvider, e.g. TICKET_OWNER. Alternatively one could always make a group, TicketOwners.

in reply to:  3 ; comment:4 by Jun Omae, 10 years ago

This might seem a bit odd, but the idea of populating the list with all users that have a permission seems logical, especially in the case that a custom permission is defined via ExtraPermissionsProvider, e.g. TICKET_OWNER.

IMO, I like allowing to specify permissions to .set_owner rather than group names. That is Trac-ish.

Alternatively one could always make a group, TicketOwners.

Personally, I use @group-name or %group-name form for group naming in permissions admin page.

in reply to:  4 comment:5 by Ryan J Ollos, 10 years ago

Replying to jomae:

This might seem a bit odd, but the idea of populating the list with all users that have a permission seems logical, especially in the case that a custom permission is defined via ExtraPermissionsProvider, e.g. TICKET_OWNER.

IMO, I like allowing to specify permissions to .set_owner rather than group names. That is Trac-ish.

I'm not sure why that would be considered more Trac-ish. Trac has pretty poor support for groups so they aren't as widely used in scenarios like this, but in this case the implementation was pretty simple. Of course there is no reason I can see that we can't support user, groups and permissions in the field.

comment:6 by Ryan J Ollos, 10 years ago

Status: new → assigned

comment:7 by Ryan J Ollos, 10 years ago

#3580 closed as a duplicate.

comment:8 by Ryan J Ollos, 10 years ago

Revised changes in log:rjollos.git:t11839.1. The set_owner field supports groups (including authenticated), permissions and users.

Last edited 10 years ago by Ryan J Ollos (previous) (diff)

comment:9 by Ryan J Ollos, 10 years ago

API Changes: modified (diff)
Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Documented in 1.1/TracWorkflow@9. Committed to trunk in [13586:13587].

Last edited 10 years ago by Ryan J Ollos (previous) (diff)

comment:10 by Ryan J Ollos, 8 years ago

See also #5425, requesting the same for the permissions attribute.

comment:11 by Ryan J Ollos, 7 years ago

In r16333, refactored to use get_users_dict method added in r13586.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.