Milestone links should not be followable on query page when user doesn't have MILESTONE_VIEW

[Ryan J Ollos]

The links should be rendered with the missing class.

[Ryan J Ollos]

trac/ticket/templates/query_results.html

@@ -90 +90 @@
                       <py:when test="name == 'reporter'">${authorinfo(value)}</py:when>
                       <py:when test="name == 'cc'">${format_emails(ticket_context, value)}</py:when>
                       <py:when test="name == 'owner' and value">${authorinfo(value)}</py:when>
-                      <py:when test="name == 'milestone'"><a py:if="value" title="View milestone" href="${href.milestone(value)}">${value}</a></py:when>
+                      <py:when test="name == 'milestone'"><py:if test="value">${resource_link(context, Resource('milestone', value), 'compact')}</py:if></py:when>
                       <py:when test="header.wikify">${wiki_to_oneliner(ticket_context, value)}</py:when>
                       <py:when test="header.wikifyblock">${wiki_to_html(ticket_context, value)}</py:when>
                       <py:otherwise>$value</py:otherwise>

trac/web/chrome.py

@@ -952 +952 @@
             'name_of': partial(get_resource_name, self.env),
             'shortname_of': partial(get_resource_shortname, self.env),
             'summary_of': partial(get_resource_summary, self.env),
+            'resource_link': partial(render_resource_link, self.env),
             'req': req,
             'abs_href': abs_href,
             'href': href,

The tooltip for the link changes from View milestone to one that is dependent on whether the milestone is completed, overdue and the due date is set (#10962). That appears to be an enhancement to me, unless there are any accessibility issues (screen readers and the like).

[Ryan J Ollos]

Committed to 1.0-stable in [13369], merged to trunk in [13370].