Opened 9 years ago
Closed 9 years ago
#11807 closed enhancement (fixed)
Trac 1.1.3dev support for SpamFilter
| Reported by: | Christian Boos | Owned by: | Dirk Stöcker |
|---|---|---|---|
| Priority: | normal | Milestone: | plugin - spam-filter |
| Component: | plugin/spamfilter | Version: | 1.1dev |
| Severity: | normal | Keywords: | |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
As there have been some clean-ups recently (#11494) enforcing the use of the new-style DB api among other things, I had to quickly fix the SpamFilter after the recent upgrade of t.e.o to r13209. I didn't have time to test thoroughly the changes, so a second look would be welcome.
Also, it seems that the SpamFilter unit-tests have a few issues (lots of OperationalError: table spamfilter_bayes already exists errors), even before my changes.
Attachments (1)
Change History (4)
by , 9 years ago
| Attachment: | spam-filter-trunk-r13209.diff added |
|---|
comment:1 by , 9 years ago
Ah. So finally old style db is dropped? I always was to lazy to update all places :-) Newer stuff uses the new interface already.
Unit tests: I don't use them, I have a live testsystem :-)
comment:2 by , 9 years ago
One note regarding unit tests thought. I think I fixed them. Above simply means, that unit tests should be done with an empty database.
comment:3 by , 9 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
See r13223. I didn't find any obvious errors and it seems to work in my instance as well, so let's try it.
You replaced some things which have not really been necessary. I'm not sure if the confusing style of code is really better sometimes :-)
Removal of the macros resulted in a fix in translation which is fine.
removal of get_db_cnx and replacement for prevnext_nav html macro