Rename 'Comments only' label in #prefs on the ticket page

[Ryan J Ollos]

As proposed in comment:13:ticket:10766, rename the checkbox label in the #prefs on the ticket page from Comments only to Hide property changes.

[Ryan J Ollos]

I'll apply the following diff in a few days if there are no comments on the change.

trac/ticket/templates/ticket.html

@@ -163 +163 @@
               </div>
               <div>
                 <input id="trac-comments-only-toggle" type="checkbox" />
-                <label for="trac-comments-only-toggle">Comments only</label>
+                <label for="trac-comments-only-toggle">Hide property changes</label>
               </div>
             </form>
           </div>

[Peter Suter]

Yes, sounds slightly better to me, too.

(Maybe even better would be Show property changes with inverted logic?)

[Ryan J Ollos]

Replying to psuter:

(Maybe even better would be Show property changes with inverted logic?)

I've given it some consideration. Two things come to mind:

• Changing from Comments only to Show property changes without an upgrade step would invert the user's saved session preference. This is hardly an issue since the user would just need to save their preference again.
• Hide property changes would default to false. The initial behavior of showing everything might be more expected and predictable for new users of Trac as well as users coming from older versions of Trac.

Overall though I don't find a particularly strong argument for one over the other: Hide property changes vs Show property changes.

[Peter Suter]

Replying to rjollos:

• Changing from Comments only to Show property changes without an upgrade step would invert the user's saved session preference. This is hardly an issue since the user would just need to save their preference again.
• Hide property changes would default to false. The initial behavior of showing everything might be more expected and predictable for new users of Trac as well as users coming from older versions of Trac.

I agree that both points would be undesirable. I thought we could avoid them, e.g. by keeping the comments_only flag internally as is, and only negating the checkbox logic somehow. But maybe it's not as simple and gets too ugly in practice.

My main argument for Show is that it avoids a kind of double negative for new users: It can be slightly confusing that show (positive) means uncheck hide (double negative). But it's not that important, so if the changes aren't simple it's probably not worth it.

[Ryan J Ollos]

Replying to psuter:

I agree that both points would be undesirable. I thought we could avoid them, e.g. by keeping the comments_only flag internally as is, and only negating the checkbox logic somehow. But maybe it's not as simple and gets too ugly in practice.

My main argument for Show is that it avoids a kind of double negative for new users: It can be slightly confusing that show (positive) means uncheck hide (double negative). But it's not that important, so if the changes aren't simple it's probably not worth it.

That seems like a good approach. I can't see a way to accomplish the change while leaving the code readable without a change to an id. Other than that, there doesn't seem to be any downside to the changes: log:rjollos.git:t11794.1.

[Ryan J Ollos]

If the CSS in [a4c13e76/rjollos.git] is deemed generally useful we could add a trac-unselectable-text class.

[Ryan J Ollos]

Committed to trunk in [13220]. Pot file refreshed in [13222].

[Ryan J Ollos]

While working on #11612, I noticed that the autopreview logic was inverted in [13220]. The issue is fixed in [13247].