Edgewall Software
Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11795 closed task (fixed)

Remove deprecated SilverCity, Enscript and PhpRenderer support

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.1.3
Component: rendering Version:
Severity: normal Keywords:
Cc:
Release Notes:

Removed support for SilverCity, Enscript and PhpRenderer syntax highlighters.

API Changes:

Description

Discussed in comment:33:ticket:11605, the components tracopt.mimeview.enscript, tracopt.mimeview.php and tracopt.mimeview.silvercity have been deprecated since Trac 1.0 or earlier.

Attachments (0)

Change History (8)

comment:1 Changed 4 years ago by Ryan J Ollos

It is looking like a large number of rules can be dropped from code.css: trunk/trac/htdocs/css/code.css@12355:89-181#L83. Does anyone see any use for those rules once the three deprecated renderers are dropped?

comment:2 Changed 4 years ago by Ryan J Ollos

Major documentation revision in 1.1/TracSyntaxColoring@2. Dependencies updated in install documentation in 1.1/TracInstall@4.

comment:3 Changed 4 years ago by Ryan J Ollos

Release Notes: modified (diff)
Status: newassigned

Proposed changes in log:rjollos.git:t11795.

comment:4 Changed 4 years ago by Christian Boos

Looks good to me! (including Wiki changes)

Last edited 4 years ago by Christian Boos (previous) (diff)

comment:5 Changed 4 years ago by Ryan J Ollos

Resolution: fixed
Status: assignedclosed

Thanks for the review. In addition to the changes in log:rjollos.git:t11795, there were a few pieces of documentation in doc/api that were removed in [13199].

comment:6 Changed 4 years ago by Jun Omae

Unit test failed…. tracopt.mimeview has been removed in [13199] but import tracopt.mimeview.tests is still leave in trac/test.py.

Traceback (most recent call last):
  File "./trac/test.py", line 494, in <module>
    unittest.main(defaultTest='suite')
  File "/usr/lib/python2.6/unittest.py", line 816, in __init__
    self.parseArgs(argv)
  File "/usr/lib/python2.6/unittest.py", line 843, in parseArgs
    self.createTests()
  File "/usr/lib/python2.6/unittest.py", line 849, in createTests
    self.module)
  File "/usr/lib/python2.6/unittest.py", line 613, in loadTestsFromNames
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/usr/lib/python2.6/unittest.py", line 598, in loadTestsFromName
    test = obj()
  File "./trac/test.py", line 460, in suite
    import tracopt.mimeview.tests
ImportError: No module named mimeview.tests
make: *** [unit-test] Error 1

comment:7 Changed 4 years ago by Ryan J Ollos

Thanks, fixed in [13200].

Build failure notifications don't seem to be going to the Google group?

comment:8 Changed 4 years ago by Jun Omae

Hmm. No pending messages in the group. I don't know why no notifications from travis-ci send to the group.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.