Highlight the whole referenced comment

[vlastimil.zima@…]

If you open a link with reference to a comment, e.g. ticket:3#comment:3 the selected comment is not much visible. Only the "comment:NUM" string in the top right corner is highlighted which doesn't show up that much.

The page is scrolled to the comment, but if the comment is one of the last the page doesn't scroll that far, actually showing a different part of history. If you get unlucky enough, page can scroll to the top of another comment, thus causing even more confusion.

I suggest to highlight the whole comment block, so its clearly visible which comment is referenced in the link.

[Ryan J Ollos]

I have felt similarly. We could also consider highlighting the entire h3:

trac/ticket/templates/ticket_change.html

@@ -39 +39 @@
   <py:def function="commentref(prefix, cnum, cls=None)">
     <a href="#comment:$cnum" class="$cls">$prefix$cnum</a>
   </py:def>
-  <h3 class="change">
+  <h3 class="change" id="comment:$cnum">
     <span class="threading"
           py:with="change_replies = replies.get(str(cnum), []) if 'cnum' in change else []">
-      <span py:if="'cnum' in change" id="comment:$cnum" class="cnum">${commentref('comment:', cnum)}</span>
+      <span py:if="'cnum' in change" class="cnum">${commentref('comment:', cnum)}</span>
       <py:if test="'replyto' in change">
         in reply to: ${commentref('&uarr;&nbsp;', change.replyto)}
         <py:if test="change_replies">; </py:if>

Highlighting the entire commment or putting a border around it might work as well.

[Jun Omae]

Sounds good. However, if the change is attachment, the h3 element would have wrong id="comment:" attribute.

-  <h3 class="change">
+  <h3 class="change" id="${'comment:%s' % cnum if 'cnum' in change else None}">

[Ryan J Ollos]

TracUpgrade#CustomizedTemplates states the we usually won't modify element ids or change CSS classes, and if we have to do so, this will be documented in the TracDev/ApiChanges pages. I haven't been rigorous about documenting template and CSS changes, but will keep it in mind for changes like the one in this ticket.

[Ryan J Ollos]

Replying to rjollos:

TracUpgrade#CustomizedTemplates states the we usually won't modify element ids or change CSS classes, and if we have to do so, this will be documented in the TracDev/ApiChanges pages. I haven't been rigorous about documenting template and CSS changes, but will keep it in mind for changes like the one in this ticket.

I suppose the changes are captured in TracDev/ApiChanges through the ticket listing wiki:TracDev/ApiChanges/1.1.2#list. So perhaps the level of detail in wiki:TracDev/ApiChanges/1.1.2@15?action=diff and wiki:TracDev/ApiChanges/1.1.2@14?action=diff isn't necessary or useful and we should just make sure to capture the detail in the API Changes field for each ticket.

[vlastimil.zima@…]

Replying to rjollos:

Highlighting the entire commment or putting a border around it might work as well.

I'd be rather for highlighting the entire comment.

[Ryan J Ollos]

It's worth considering how the behavior compares to wiki TracLinks: TracReports#ChangingSortOrder. We can see in that case the whole heading is highlighted.

If we choose to highlight only the heading, we can also try to make it easy enough to add some custom CSS for highlighting the whole comment (via TracInterfaceCustomization#SiteAppearance).

[Ryan J Ollos]

We'll consider highlighting the entire comment when the user interface is refreshed in a future milestone.

Fixed in [13201].