Official support for uwsgi

[anonymous]

When using uwsgi + refresh the site fast you get tons of:

Traceback (most recent call last):
  File "/home/trac/uwsgi-test/local/lib/python2.7/site-packages/trac/web/main.py", line 474, in dispatch_request
    return _dispatch_request(req, env, env_error)
  File "/home/trac/uwsgi-test/local/lib/python2.7/site-packages/trac/web/main.py", line 513, in _dispatch_request
    send_internal_error(env, req, sys.exc_info())
  File "/home/trac/uwsgi-test/local/lib/python2.7/site-packages/trac/web/main.py", line 630, in send_internal_error
    req.send_error(exc_info, status=500, env=env, data=data)
  File "/home/trac/uwsgi-test/local/lib/python2.7/site-packages/trac/web/api.py", line 581, in send_error
    self.write(data)
  File "/home/trac/uwsgi-test/local/lib/python2.7/site-packages/trac/web/api.py", line 660, in write
    self._write(data)
IOError: write error

I see that there is a special case for mod_wsgi, maybe you could add one for uwsgi too? ​http://trac.edgewall.org/browser/branches/1.0-stable/trac/web/api.py#L666

Saw that atleast jomae uses uwsgi…

Also, is there any recommended conf for uwsgi? threads - on/off? and so on…

[Jun Omae]

I quickly tried to reproduce it. But cannot reproduce. However, I think that you can try to use ​disable-write-exception.

Adding the case of uWSGI, patch is the following.

trac/web/api.py

@@ -661 +661 @@
         except (IOError, socket.error), e:
             if e.args[0] in (errno.EPIPE, errno.ECONNRESET, 10053, 10054):
                 raise RequestDone
-            # Note that mod_wsgi raises an IOError with only a message
-            # if the client disconnects
+            # Note that some wsgi containers raise an IOError with only a
+            # message if the client disconnects
             if 'mod_wsgi.version' in self.environ and \
                e.args[0] in ('failed to write data',
                              'client connection closed'):
                 raise RequestDone
+            if 'uwsgi.version' in self.environ and e.args[0] == 'write error':
+                raise RequestDone
             raise
 
     # Internal methods

Generally, patch is like this.

trac/web/api.py

@@ -661 +661 @@
         except (IOError, socket.error), e:
             if e.args[0] in (errno.EPIPE, errno.ECONNRESET, 10053, 10054):
                 raise RequestDone
-            # Note that mod_wsgi raises an IOError with only a message
-            # if the client disconnects
-            if 'mod_wsgi.version' in self.environ and \
-               e.args[0] in ('failed to write data',
-                             'client connection closed'):
+            # Note that some wsgi containers raise an IOError with only a
+            # message if the client disconnects. Normally, an IOError has both
+            # an errno and a message.
+            if len(e.args) == 1 and isinstance(e.args[0], basestring):
                 raise RequestDone
             raise
 

[anonymous]

Only thing i did was the F5 the page many times quickly, thanks for the patch!

What about threads? ​http://uwsgi-docs.readthedocs.org/en/latest/WSGIquickstart.html?highlight=threads#a-note-on-python-threads

Is it something trac uses?

[Jun Omae]

I don't know that. I've used uWSGI for a testing purpose only. You can ask it on the MailingList or in the IrcChannel.

[Jun Omae]

#9973 is the same on mod_wsgi.

[Ryan J Ollos]

Moved ticket assigned to next-stable-1.0.x since maintenance of 1.0.x is coming to a close. Please move the ticket back if it's critical to fix on 1.0.x.

[Ryan J Ollos]

Milestone renamed