Edgewall Software
Modify

Opened 6 years ago

Closed 6 years ago

#11685 closed defect (fixed)

Wrong revision graph if [git] cached_repository = enabled

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.0.2
Component: plugin/git Version: 1.0-stable
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Fix wrong revision graph for cached git repository.

API Changes:
Internal Changes:

Description

If [git] cached_repository = enabled, revision graph in log view for git repository is wrong. Trac 1.0, 1.0.1 and 1.0-stable have the issue.

The following images is shown with pygit2.

[git] cached_repository = enabled:

[git] cached_repository = disabled:

Attachments (2)

revgraph-cached.png (44.4 KB ) - added by Jun Omae 6 years ago.
revgraph-non-cached.png (44.8 KB ) - added by Jun Omae 6 years ago.

Download all attachments as: .zip

Change History (4)

by Jun Omae, 6 years ago

Attachment: revgraph-cached.png added

by Jun Omae, 6 years ago

Attachment: revgraph-non-cached.png added

comment:1 by Jun Omae, 6 years ago

Milestone: next-stable-1.0.x1.0.2
Owner: set to Jun Omae
Status: newassigned

Proposed changes in jomae.git@t11685.

Repository.parent_revs() is used since CachedRepository.parent_revs() is missing. Then, if non linear changesets, it returns wrong revisions. In the branch, added CachedRepository.parent_revs().

comment:2 by Jun Omae, 6 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed in [12974] and merged to trunk in [12975].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.