Improve layout of report edit page

[Ryan J Ollos]

The styling of the Report Edit page could be improved and made more consistent with other Trac pages by adding a fieldset and making some other minor changes. This was first mentioned in comment:10:ticket:11499.

[Ryan J Ollos]

It seems the message extraction does not work correctly for this case,

<title py:choose="">
  <py:when test="new_report" i18n:msg="">Create New Report</py:when>
  <py:otherwise i18n:msg="id,title">Edit Report {$report.id} $report.title</py:otherwise>
</title>

but does for this case,

<py:choose test="new_report">
  <title py:when="True">Create New Report</title>
  <title py:otherwise="" i18n:msg="id,title">Edit Report {$report.id} $report.title</title>
</py:choose>

Tested with Genshi 0.7.

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t11664. The last changeset on the branch ([b3f86bbf/rjollos.git])is a refactoring that is only intended for the trunk.

[Ryan J Ollos]

Does anyone know if there is any reason to leave the size attribute on input elements that have a CSS rule width: 100%? I was thinking it could be needed for older browsers, but in the testing with older versions on IE (in emulation mode) it doesn't seem to make a difference.

[Ryan J Ollos]

Minor revisions in log:rjollos.git:t11664.1.

It could be better to apply these changes to trunk for the reason described in comment:13:ticket:11499, but the current styling of the Report Edit page is inconsistent with other pages, which might suggest this should be fixed on 1.0-stable.

[Jun Omae]

Replying to rjollos:

Does anyone know if there is any reason to leave the size attribute on input elements that have a CSS rule width: 100%? I was thinking it could be needed for older browsers, but in the testing with older versions on IE (in emulation mode) it doesn't seem to make a difference.

Nothing is wrong to remove it. The width:100% property is used even if IE 6.

[Ryan J Ollos]

Thanks for the review. Committed to 1.0-stable in [12915], merged to trunk in [12916]. Refactoring committed to trunk in [12917].