Edgewall Software

Opened 8 years ago

Closed 8 years ago

#11653 closed enhancement (fixed)

Don't display version or revision in single-file plugin if keyword is not expanded

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.2
Component: admin/web Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

The version/revision attribute of a single-file plugin is not displayed on the plugin admin page if the SVN keyword is not expanded.

API Changes:
Internal Changes:

Description (last modified by Ryan J Ollos)

Single-file plugins use the version and revision module attributes to specify the plugin version, and this version is displayed on the plugin admin page: trunk/trac/loader.py?rev=12785&marks=182-185#L179.

The attributes may be set to an svn keyword that gets expanded, however the svn keyword won't get expanded if the source is downloaded in a zip, or the SVN repository is cloned to Git. This leads to only Rev being displayed. In this case, it would be better to display nothing.

Attachments (1)

PluginAdminPage.png (18.4 KB ) - added by Ryan J Ollos 8 years ago.

Download all attachments as: .zip

Change History (5)

by Ryan J Ollos, 8 years ago

Attachment: PluginAdminPage.png added

comment:1 by Ryan J Ollos, 8 years ago

Description: modified (diff)

comment:2 by Ryan J Ollos, 8 years ago

Proposed change in log:rjollos.git:t11653. Tests will be added.

comment:3 by Ryan J Ollos, 8 years ago

Milestone: next-stable-1.0.x1.0.2
Status: newassigned

comment:4 by Ryan J Ollos, 8 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed to 1.0-stable in [12996], merged to trunk in [12997].

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.