"Repository '' not found" when navigating to /log page and the default repository is not defined

[Ryan J Ollos]

When the default repository is not defined, the following error is seen when navigating to /log:

When the default repository is defined, /log redirects to the default repository.

We should show the same error that is displayed when navigating to /changeset and default repository is not defined:

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t11599.

[Jun Omae]

Changing the following in [716b57d6/rjollos.git#file1], I don't think .split('/')[0] is needed. Since repository name can include / characters, we cannot determine whether repository name is a first segment in path or entire of path.

-                raise TracError(_("Repository '%(repo)s' not found", 
-                                  repo=reponame or new_path.strip('/'))) 
+                raise TracError(_("Repository '%(repo)s' not found.", 
+                                  repo=reponame or 
+                                       new_path.lstrip('/').split('/')[0])) 

[Jun Omae]

Another thing, we could add tests for this issue as unit tests. I like to use unit tests rather than functional tests. Functional tests is very slow.

e.g. branches/1.0-stable/tracopt/versioncontrol/git/tests/git_fs.py@12720:276-281,283-288#L257​.

[Ryan J Ollos]

Replying to jomae:

Since repository name can include / characters, we cannot determine whether repository name is a first segment in path or entire of path.

In that case we should probably change the error message to something like Path '%(path)s' not found.

[Ryan J Ollos]

Revised changes in log:rjollos.git:t11599.2.

[Jun Omae]

I am not sure about the changes in [12798]. normalize_rev can raise NoSuchChangeset exceptions but normalize_path never raise the exceptions….

[Ryan J Ollos]

The error described in comment:7 has been fixed, changes committed to 1.0-stable in [12798:12799,12802], merged to trunk in [12800:12801,12803].