Edgewall Software
Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#11598 closed enhancement (fixed)

Replace b tags

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.2
Component: general Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Replaced b tags with strong.

API Changes:

Description

There are several instances of b tags that should probably be replaced with strong tags.

The codebase was inspected after comment:12:ticket:6634:

$ grep -r tag.\b\(
sample-plugins/Timestamp.py:        return tag.b(format_datetime(t, '%c'))
trac/notification.py:                    "configuration.", from_=tag.b('[notification] smtp_from'),
trac/notification.py:                    reply_to=tag.b('[notification] smtp_replyto')))))
trac/timeline/web_ui.py:                  tag.b(exception_to_unicode(exc)), class_='message'),
trac/wiki/intertrac.py:                yield tag.tr(tag.td(tag.b(prefix)),
trac/wiki/intertrac.py:                             tag.td('Alias for ', tag.b(intertrac)))
trac/wiki/intertrac.py:                    yield tag.tr(tag.td(tag.a(tag.b(prefix),
trac/wiki/default-pages/WikiMacros:        return tag.b(format_datetime(t, '%c'))
trac/versioncontrol/web_ui/changeset.py:                [tag.li(tag.b(path) if isdir else path)

Attachments (0)

Change History (5)

comment:1 by Ryan J Ollos, 6 years ago

Wiki page edited in version 45. Proposed changes in log:rjollos.git:t11598.

comment:2 by Ryan J Ollos, 6 years ago

Release Notes: modified (diff)
Status: newassigned

comment:3 by Ryan J Ollos, 6 years ago

Resolution: fixed
Status: assignedclosed
Type: taskenhancement

Committed to 1.0-stable in [12743], merged to trunk in [12744].

comment:4 by Jun Omae, 6 years ago

The <b> tag is used in some template files.

$ grep -r --include='*.html' '<strong\b' trac tracopt | wc -l
48
$ grep -r --include='*.html' '<b\b' trac tracopt | wc -l
4
$ grep -r --include='*.html' '<b\b' trac tracopt
trac/versioncontrol/templates/repository_index.html:              <b py:strip="repoinfo.alias != ''">
trac/wiki/templates/wiki_edit_form.html:        <b>Note:</b> See <a href="${href.wiki('WikiFormatting')}">WikiFormatting</a> and
trac/wiki/templates/wiki_edit.html:          <p i18n:msg=""><b>If you save right away, you risk to revert those changes</b>
trac/templates/error.html:                        line <b>${frame.lineno + 1}</b>, in</span>

comment:5 by Ryan J Ollos, 6 years ago

Thanks. Changes to template files committed to 1.0-stable in [12749], merged to trunk in [12750].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.