Email obfuscation for owner field in csv download

[Jun Omae]

If owner field has email address, csv download of ticket and query page renders the email address without obfuscation.

• ​http://trac.edgewall.org/demo-0.12/ticket/6202
• ​http://trac.edgewall.org/demo-0.12/query?id=6202

Csv download of report page doesn't have the issue.

[Jun Omae]

Proposed changes in jomae.git@t11594.

[Ryan J Ollos]

The patch looks good.

Do you think it would be a good idea to define in the TicketSystem class the list of fields that might contain an email address? I quickly implemented a possible change in log:rjollos.git:t11594.2 (it would need more careful study and testing before committing).

On the one hand it would be nice to define the fields in a single location, however I worry that the change would clutter up the API too much, so maybe there is a better way. Also, we might want to consider this in another ticket so that it doesn't hold up this fix.

[Jun Omae]

Thanks for response.

Trac currently handles as different from owner, reporter and cc field, but adding properties for email fields sounds good. (The owner and reporter have only one of username or email address. The cc field has multiple entries.)

Also, I don't think that @cached decorator is needed because fields properties is cached. The reason @cached is used for fields and custom_fields is retrieving values from trac.ini via self.config.

trac/ticket/api.py

@@ -389 +389 @@
     def get_email_fields(self):
         return copy.deepcopy(self.email_fields)
 
-    @cached
-    def email_fields(self, db):
+    @property
+    def email_fields(self):
         return [f for f in self.fields
-                if f['name'] in ('reporter', 'owner', 'cc')]
+                  if f['name'] in ('reporter', 'owner', 'cc')]
 
     def get_time_fields(self):
         return copy.deepcopy(self.time_fields)
 
-    @cached
-    def time_fields(self, db):
+    @property
+    def time_fields(self):
         return [f for f in self.fields if f['type'] == 'time']
 
     def get_field_synonyms(self):

[Jun Omae]

Committed to 0.12-stable in [12766] and merged to 1.0-stable in [12767] and to trunk in [12768].

[Ryan J Ollos]

Replying to rjollos:

Do you think it would be a good idea to define in the TicketSystem class the list of fields that might contain an email address? I quickly implemented a possible change in log:rjollos.git:t11594.2 (it would need more careful study and testing before committing).

Created #11861 to investigate this further.