Edgewall Software
Modify

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#11541 closed enhancement (fixed)

Allow highlight markers on browser TracLink without revision, or document limitation

Reported by: Ryan J Ollos Owned by: Christian Boos
Priority: normal Milestone: 0.12.6
Component: wiki system Version:
Severity: normal Keywords: traclinks
Cc: Branch:
Release Notes:

Added TracLinks documentation explaining proper usage of revision, highlighted line numbers and target line number.

API Changes:

Description

The following is a valid TracLink: tags/trac-1.0/setup.py@11307:19-25#L15

However, if the revision @11307 is omitted, we don't get a valid TracLink: tags/trac-1.0/setup.py:19-25#L15

If we add a @ without a revision number, the TracLink is valid: tags/trac-1.0/setup.py@:19-25#L15

Documentation changes would be applied here: TracLinks#VersionControlrelatedlinks.

Attachments (0)

Change History (6)

comment:1 by Ryan J Ollos, 6 years ago

Summary: Document restriction or allow highlight markers on browser TracLink without revisionAllow highlight markers on browser TracLink without revision or document limitation

comment:2 by Christian Boos, 6 years ago

Like this: TracLinks@91?

comment:3 by Ryan J Ollos, 6 years ago

The documentation is helpful. Do you think we should also try to support highlighting with the @ omitted? I haven't looked at the code yet to determine how much effort the change will require.

comment:4 by Christian Boos, 6 years ago

Doing without the @ separator implies using : as a separator, so source:/path/filename:1 will no longer be seen as a valid link… It won't be a problem for most people, I suppose, as : is not even a valid part of a file name on Windows (while @ is!).

But the reasoning for having a mandatory @ before specifying the range was that this way you make it clear that omitting the revision was intentional and not just an oversight (#3745).

comment:5 by Ryan J Ollos, 5 years ago

Milestone: next-stable-1.0.x0.12.6
Release Notes: modified (diff)
Resolution: fixed
Status: newclosed
Summary: Allow highlight markers on browser TracLink without revision or document limitationAllow highlight markers on browser TracLink without revision, or document limitation
Type: defectenhancement

That logic seems sound. Thank you for the documentation update.

comment:6 by Ryan J Ollos, 5 years ago

Owner: set to Christian Boos

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.