Should not use fnmatch which is case-insensitive and platform dependent

[Jun Omae]

Trac core uses fnmatch.fnmatch method. The method internally use os.path.normcase and is depended on platform. I don't think we should use the methods for wildcard-globbing.

We should use fnmatch.translate instead.

Windows:

Python 2.4.4 (#71, Oct 18 2006, 08:34:43) [MSC v.1310 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> from fnmatch import fnmatch
>>> fnmatch('abc/def', r'a*/def')
True
>>> fnmatch('abc/def', r'a*\def')
True
>>> fnmatch('abc/def', r'a*\DEF')
True

Linux:

Python 2.4.3 (#1, Jan  9 2013, 06:49:54)
[GCC 4.1.2 20080704 (Red Hat 4.1.2-54)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from fnmatch import fnmatch
>>> fnmatch('abc/def', 'a*/def')
True
>>> fnmatch('abc/def', r'a*\def')
False

$ grep -wr --include='*.py' fnmatch trac tracopt
trac/versioncontrol/web_ui/browser.py:from fnmatch import fnmatchcase
trac/wiki/macros.py:from fnmatch import fnmatchcase
trac/web/main.py:import fnmatch
trac/web/main.py:                 and not any(fnmatch.fnmatch(path[:-1], pattern)
tracopt/perm/authz_policy.py:from fnmatch import fnmatch
tracopt/perm/authz_policy.py:            if fnmatch(resource_key, resource_glob):

[Peter Suter]

fnmatch.fnmatchcase should be ok, right?

[Jun Omae]

Yes. The fnmatchcase method doesn't use os.path.normcase. I've confirmed fnmatch.py source and actually verified.

>>> import os
>>> os.name
'nt'
>>> from fnmatch import fnmatchcase
>>> fnmatchcase('abc/def', r'a*/def')
True
>>> fnmatchcase('abc/def', r'a*\def')
False
>>> fnmatchcase('abc/def', r'a*/DEF')
False

[Jun Omae]

Especially, in the case of AuthzPolicy, name of resource is defined using wildcards in section of its configuration file.

[wiki:WikiStart*]
...

I don't think that a user expects the matching is case-insensitive.

[Jun Omae]

Proposed changes in jomae.git@t11528.

[Jun Omae]

I confirmed on Windows. Committed in [12845] and merged to trunk in [12846].