Edgewall Software
Modify

Opened 10 years ago

Last modified 7 months ago

#11527 new defect

Some unexpected behaviors on the history page

Reported by: Ryan J Ollos Owned by:
Priority: normal Milestone: next-stable-1.6.x
Component: general Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description (last modified by Ryan J Ollos)

While testing changes for #11517, I noticed the following undesirable behaviors.

  1. Wiki history: diff of version 1 with version 1 results in Changes between Initial Version and Version 1 of WikiStart, however Initial Version links to /wiki/WikiStart?version=0, which shows a Create this page button.

For the case of wiki pages, version 0 is the non-existent page, so the behavior is not surprising. It would be better though to not have Initial Version be a link.

  1. Wiki history: diff of version X and X results in display of a diff between version X and X - 1 (this behavior is probably okay).
  1. Wiki history: Diff of version 2 and 1 results in display of a page indicating a diff of version 1 and 1, with a Delete version 1 button displayed.

  1. Ticket history: Diff of version 1 and 1 for ticket history or ticket comment history results in a TracError.

The other ticket history behaviors are more sensible in that a diff of version 1 and 2 is the same as a diff of version 2 and 1. A diff of version 2 and 2 displays a diff of versions 1 and 2.

I think we could fix issue (4) with the ticket history, and then make the wiki history behave more like the ticket history. JavaScript code that conditionally disabled buttons could be added to guide sensible selections, after the major issues have been fixed in the server-side code.

Attachments (7)

WikiChangesDiff11.png (11.9 KB ) - added by Ryan J Ollos 10 years ago.
WikiHistoryDiff11.png (26.4 KB ) - added by Ryan J Ollos 10 years ago.
WikiInitialVersion.png (18.0 KB ) - added by Ryan J Ollos 10 years ago.
WikiHistory21.png (27.0 KB ) - added by Ryan J Ollos 10 years ago.
WikiChangesDiff21.png (21.6 KB ) - added by Ryan J Ollos 10 years ago.
TicketCommentHistory11.png (12.9 KB ) - added by Ryan J Ollos 10 years ago.
TicketHistory11.png (12.6 KB ) - added by Ryan J Ollos 10 years ago.

Download all attachments as: .zip

Change History (15)

by Ryan J Ollos, 10 years ago

Attachment: WikiChangesDiff11.png added

by Ryan J Ollos, 10 years ago

Attachment: WikiHistoryDiff11.png added

by Ryan J Ollos, 10 years ago

Attachment: WikiInitialVersion.png added

by Ryan J Ollos, 10 years ago

Attachment: WikiHistory21.png added

by Ryan J Ollos, 10 years ago

Attachment: WikiChangesDiff21.png added

comment:1 by Ryan J Ollos, 10 years ago

Milestone: 1.0.21.0.3

by Ryan J Ollos, 10 years ago

Attachment: TicketCommentHistory11.png added

by Ryan J Ollos, 10 years ago

Attachment: TicketHistory11.png added

comment:2 by Ryan J Ollos, 10 years ago

Description: modified (diff)

comment:3 by Ryan J Ollos, 10 years ago

#7276 reports the issues described in (1).

comment:4 by Ryan J Ollos, 9 years ago

Status: newassigned

comment:5 by Ryan J Ollos, 9 years ago

Milestone: 1.0.3next-stable-1.0.x
Owner: Ryan J Ollos removed
Status: assignednew

comment:6 by Ryan J Ollos, 7 years ago

Milestone: next-stable-1.0.xnext-stable-1.2.x

Moved ticket assigned to next-stable-1.0.x since maintenance of 1.0.x is coming to a close. Please move the ticket back if it's critical to fix on 1.0.x.

comment:7 by Ryan J Ollos, 4 years ago

Milestone: next-stable-1.2.xnext-stable-1.4.x

comment:8 by Ryan J Ollos, 7 months ago

Milestone: next-stable-1.4.xnext-stable-1.6.x

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.