Edgewall Software
Modify

Opened 7 years ago

Closed 7 years ago

#11500 closed enhancement (fixed)

Refactor TracadminTestCase to simplify test cases

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.2
Component: admin/console Version:
Severity: normal Keywords: test cases
Cc: Branch:
Release Notes:

Improved test harness in trac.admin.tests.console.

API Changes:

The method assertExpectedResult should be used to assert the proper output from trac-admin test cases in trac.admin.tests.console.

Internal Changes:

Description

I've been working on adding some test cases for console admin commands, and it appears that the existing test cases could be simplified in a small way. I'll propose some changes for review.

Attachments (0)

Change History (4)

comment:1 by Ryan J Ollos, 7 years ago

Milestone: next-stable-1.0.x1.0.2
Status: newassigned

It appears that the workaround in the test case from [7775] is not needed since [8333].

Changes can be found in log:rjollos.git:t11500.

comment:2 by Ryan J Ollos, 7 years ago

A few additional changes have been added in [0f30513a/rjollos.git].

comment:3 by Jun Omae, 7 years ago

Looks good to me and verified with the following environments.

  • Python 2.5 - 2.7 with SQLite, PostgreSQL and MySQL on Linux
  • Python 2.5 - 2.6 with SQLite on Windows

comment:4 by Ryan J Ollos, 7 years ago

API Changes: modified (diff)
Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Thanks for testing. I've run the tests on Linux with PostreSQL 9.1.11, MySQL 5.5.34; Python 2.5, 2.6, 2.7.

Committed to 1.0-stable in [12537], merged to trunk in [12538].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.