#11488 closed enhancement (wontfix)
The setRevertHandler in ticket page doesn't revert the values for MULTIPLE select field.
Reported by: | Owned by: | ||
---|---|---|---|
Priority: | low | Milestone: | |
Component: | ticket system | Version: | 1.0-stable |
Severity: | minor | Keywords: | |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
I'm making the multi-selectbox plugin (almost made) using list
custom format of text
type introduced since 1.0. The list
format treats multiple value delimited space.
http://trac.edgewall.org/wiki/TracTicketsCustomFields
I know Trac haven't supported multiple value of field, so I'm making above plugin. And then, I encountered that reverting multiple value doesn't work properly, it only works to remove all values. After debugging, I found the setRevertHandler function haven't handled the multiple select field.
I made a patch to support the multiple select field, though it expects the value delimited spaces. Could you merge it? I think it's no side effect even if Trac doesn't need it …
Attachments (1)
Change History (4)
by , 11 years ago
Attachment: | support-multipleselct-for-reverthandler.patch added |
---|
comment:2 by , 11 years ago
Milestone: | 1.0.2 |
---|---|
Resolution: | → wontfix |
Status: | new → closed |
It really doesn't make any sense for us to have code in Trac that supports plugins. I'm sure that's not what you want to hear, but if we included code for the sake of supporting plugins, we'd eventually end up with a mess on our hands.
If you include the code directly in your plugin, it will work with all 1.0.x versions of Trac rather than just 1.0.2 and later.
I looked at your plugin and the code looks pretty good. Perhaps you'd like to try implementing #918?
comment:3 by , 11 years ago
Definitely, I think so if I am you.
In essence, Trac should support multiple value of field, so we focus on implementing #918. Maybe not now, I would like to do it.
The multi-selectbox plugin is here:
th:TracMultiSelectBoxPlugin