Edgewall Software
Modify

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#11488 closed enhancement (wontfix)

The setRevertHandler in ticket page doesn't revert the values for MULTIPLE select field.

Reported by: t2y <tetsuya.morimoto@…> Owned by:
Priority: low Milestone:
Component: ticket system Version: 1.0-stable
Severity: minor Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

I'm making the multi-selectbox plugin (almost made) using list custom format of text type introduced since 1.0. The list format treats multiple value delimited space.

http://trac.edgewall.org/wiki/TracTicketsCustomFields

I know Trac haven't supported multiple value of field, so I'm making above plugin. And then, I encountered that reverting multiple value doesn't work properly, it only works to remove all values. After debugging, I found the setRevertHandler function haven't handled the multiple select field.

I made a patch to support the multiple select field, though it expects the value delimited spaces. Could you merge it? I think it's no side effect even if Trac doesn't need it …

Attachments (1)

support-multipleselct-for-reverthandler.patch (919 bytes ) - added by t2y <tetsuya.morimoto@…> 10 years ago.

Download all attachments as: .zip

Change History (4)

by t2y <tetsuya.morimoto@…>, 10 years ago

comment:1 by t2y <tetsuya.morimoto@…>, 10 years ago

The multi-selectbox plugin is here:

th:TracMultiSelectBoxPlugin

Last edited 10 years ago by Ryan J Ollos (previous) (diff)

comment:2 by Ryan J Ollos, 10 years ago

Milestone: 1.0.2
Resolution: wontfix
Status: newclosed

It really doesn't make any sense for us to have code in Trac that supports plugins. I'm sure that's not what you want to hear, but if we included code for the sake of supporting plugins, we'd eventually end up with a mess on our hands.

If you include the code directly in your plugin, it will work with all 1.0.x versions of Trac rather than just 1.0.2 and later.

I looked at your plugin and the code looks pretty good. Perhaps you'd like to try implementing #918?

comment:3 by t2y <tetsuya.morimoto@…>, 10 years ago

Definitely, I think so if I am you.

In essence, Trac should support multiple value of field, so we focus on implementing #918. Maybe not now, I would like to do it.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none) to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.