[PATCH] branch:r1 leads AttributeError if the default repository is not a mercurial repository

[Jun Omae]

When the default repository is not a mercurial repository, branch:r1 in wiki leads an AttributeError.

2014-01-08 14:08:05,579 Trac[main] ERROR: Internal Server Error:
Traceback (most recent call last):
  File "/home/jun66j5/venv/trac/0.12.5/lib/python2.4/site-packages/trac/web/main.py", line 522, in _dispatch_request
    dispatcher.dispatch(req)
  File "/home/jun66j5/venv/trac/0.12.5/lib/python2.4/site-packages/trac/web/main.py", line 264, in dispatch
    content_type)
  File "/home/jun66j5/venv/trac/0.12.5/lib/python2.4/site-packages/trac/web/chrome.py", line 876, in render_template
    encoding='utf-8')
  ...
  File "/home/jun66j5/venv/trac/0.12.5/lib/python2.4/site-packages/trac/ticket/templates/ticket_box.html", line 77, in <Expression u'wiki_to_html(context, ticket.description, escape_newlines=preserve_newlines)'>
    ${wiki_to_html(context, ticket.description, escape_newlines=preserve_newlines)}
  File "/home/jun66j5/venv/trac/0.12.5/lib/python2.4/site-packages/trac/util/compat.py", line 83, in newfunc
    return func_(*(args + fargs), **dict(kwargs, **fkwargs))
  File "/home/jun66j5/venv/trac/0.12.5/lib/python2.4/site-packages/trac/wiki/formatter.py", line 1501, in format_to_html
    return HtmlFormatter(env, context, wikidom).generate(escape_newlines)
  File "/home/jun66j5/venv/trac/0.12.5/lib/python2.4/site-packages/trac/wiki/formatter.py", line 1456, in generate
    escape_newlines)
  File "/home/jun66j5/venv/trac/0.12.5/lib/python2.4/site-packages/trac/wiki/formatter.py", line 1243, in format
    result = re.sub(self.wikiparser.rules, self.replace, line)
  File "/home/jun66j5/venv/trac/0.12.5/lib/python2.4/sre.py", line 142, in sub
    return _compile(pattern, 0).sub(repl, string, count)
  File "/home/jun66j5/venv/trac/0.12.5/lib/python2.4/site-packages/trac/wiki/formatter.py", line 1161, in replace
    replacement = self.handle_match(fullmatch)
  File "/home/jun66j5/venv/trac/0.12.5/lib/python2.4/site-packages/trac/wiki/formatter.py", line 1157, in handle_match
    return internal_handler(match, fullmatch)
  File "/home/jun66j5/venv/trac/0.12.5/lib/python2.4/site-packages/trac/wiki/formatter.py", line 533, in _shref_formatter
    return self._make_link(ns, target, match, match, fullmatch)
  File "/home/jun66j5/venv/trac/0.12.5/lib/python2.4/site-packages/trac/wiki/formatter.py", line 590, in _make_link
    fullmatch)
  File "/home/jun66j5/src/trac/edgewall/svn/plugins/0.12/mercurial-plugin/tracext/hg/backend.py", line 435, in _format_link
    for b, n in repos.repo.branchtags().items():
AttributeError: 'SvnCachedRepository' object has no attribute 'repo'

Workaround:

tracext/hg/backend.py

@@ -430 +430 @@
                         break
                     context = context.parent
                 repos = rm.get_repository(reponame)
-            if repos:
+            if isinstance(repos, MercurialRepository):
                 if ns == 'branch':
                     for b, n in repos.repo.branchtags().items():
                         if repos.to_u(b) == rev:

[Jun Omae]

I'll apply the patch.

[Jun Omae]

Committed in [7c49d0e31747/mercurial-plugin] on 0.12 branch and merged in [a311aa01ebcb/mercurial-plugin] on 1.0 branch.

[anonymous]

Replying to jomae:

[a311aa01ebcb/mercurial-plugin]

Quickjump should list all bookmarks, not only those of current revision.

Also Repository.get_bookmarks() API would be useful.

[Jun Omae]

Replying to anonymous:

Replying to jomae:

[a311aa01ebcb/mercurial-plugin]

Quickjump should list all bookmarks, not only those of current revision.

Also Repository.get_bookmarks() API would be useful.

Why do you post this comment here? Visit #11995.

[anonymous]

Sorry, the merge confused me.

[Jun Omae]

Replying to anonymous:

Replying to jomae:

[a311aa01ebcb/mercurial-plugin]

Quickjump should list all bookmarks, not only those of current revision.

Also Repository.get_bookmarks() API would be useful.

Created #12177 for your suggestion. Thanks.