Edgewall Software

Opened 7 years ago

Closed 7 years ago

#11306 closed enhancement (fixed)

Replace uses of `has_key` with `in`

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.2
Component: general Version:
Severity: normal Keywords: python3
Cc: Branch:
Release Notes:

Replaced uses of deprecated has_key with in.

API Changes:
Internal Changes:

Description (last modified by Ryan J Ollos)

Since has_key is formally deprecated since Python 2.6 and even removed in Python 3.0, and I've been removing these in various refactoring changesets (e.g. [11956]), I thought it might be better to create a ticket and replace these everywhere at once.

Additionally, it sounds like this will give a small performance improvement (negligible for nearly all cases I'm sure), and an increment towards #10083.

Attachments (0)

Change History (4)

comment:1 by Ryan J Ollos, 7 years ago

Description: modified (diff)

comment:2 by Ryan J Ollos, 7 years ago

Milestone: next-stable-1.0.x1.0.2
Status: newassigned

comment:3 by Ryan J Ollos, 7 years ago

Proposed changes can be found in rjollos.git:t11306.

comment:4 by Ryan J Ollos, 7 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed to 1.0-stable in [12083] and merged to trunk in [12085].

Fix for tabs in bugzilla2trac.py, which had also been noted in comment:3:ticket:11006, committed to 1.0-stable in [12084] and merged to trunk in [12086].

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.