Edgewall Software
Modify

Opened 17 years ago

Closed 14 years ago

#1119 closed defect (fixed)

Links in timeline wrong

Reported by: anonymous Owned by: Christian Boos
Priority: high Milestone: 0.11.3
Component: timeline Version: 0.11-stable
Severity: major Keywords: https timeline links absolute relative
Cc: jmberghold@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Any links in the sub-text under each timeline item redirects to an http:// URL despite my install being https://.

For example: 13:01 Changeset [88] by David

Issue #950: Readability and documentation of code has been improved.

The first link, "[88]" goes to the correct location, ie. https://blah.blah… but the second link, "#950" goes to http://blah.blah

Attachments (0)

Change History (6)

comment:1 by anonymous, 17 years ago

Taking a closer look, this problem seems to be caused by the fact that calls to wiki_to_html in Timeline.py contain the parameter "absurls=1". Changing all the "absurls=1" to "absurls=0" appears to fix the problem.

comment:2 by Christopher Lenz, 17 years ago

Milestone: 0.9
Owner: changed from Jonas Borgström to Christopher Lenz
Priority: normalhigh
Severity: minormajor
Status: newassigned

comment:3 by Christopher Lenz, 17 years ago

Resolution: fixed
Status: assignedclosed

This should have been fixed by [1230].

comment:4 by qbik, 14 years ago

Keywords: absolute relative added
Milestone: 0.90.11.3
Priority: highnormal
Resolution: fixed
Status: closedreopened
Version: 0.80.11-stable

The same appears in version 0.11.3. Links in timeline are created with absolute path. Error scenario: Tracd server running in server A apache server B with rewrites in .htaccess pointing to server A.

Links in timeline points to server A instead of B.

As before, changing all the "absurls=True" to "absurls=False" (function 'process_request') appears to fix the problem.

in reply to:  4 comment:5 by Christian Boos, 14 years ago

Owner: changed from Christopher Lenz to Christian Boos
Priority: normalhigh
Status: reopenednew

Replying to qbik:

The same appears in version 0.11.3. Links in timeline are created with absolute path.

Well spotted, it's a copy/paste error in r7610.

comment:6 by Christian Boos, 14 years ago

Resolution: fixed
Status: newclosed

Fixed in [7754], thanks for notifying us.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.