#950 closed defect (fixed)
no email notification on ticket change via SVN commit command "refs"
| Reported by: | Owned by: | Jonas Borgström | |
|---|---|---|---|
| Priority: | low | Milestone: | 0.9 |
| Component: | ticket system | Version: | 0.8 |
| Severity: | normal | Keywords: | |
| Cc: | hw@… | Branch: | |
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
When you checkin a changeset and use the "refs #<ticket_nr>" command no notification is send. Normal ticket change like adding comment works well.
Attachments (3)
Change History (17)
comment:1 by , 19 years ago
comment:4 by , 19 years ago
| Milestone: | → 0.9 |
|---|---|
| Version: | devel → 0.8 |
We just checked, also closing via "post-commt hook" does not send a notification email.
comment:5 by , 19 years ago
I believe the post-commit hook modifies the database directly. The module that provides the functionality needed should probably be refactored so that the post-commit hook can use it to make the changes.
comment:7 by , 19 years ago
as I mentioned in #1508, the post-commit hook uses ticket.save_changes(). I don't mind helping to fix this, but need to know from the devs if it should be fixed in the hook (by adding a call to whatever method sends the emails) or in the trac code (by making save_changes() send the email).
comment:8 by , 19 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
This was actually fixed a while back with [1497], but just got overlooked in the list of fixed tickets. I've tested it out and it's working as expected.
comment:9 by , 19 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Oops, my mistake. This still doesn't work. I was testing stuff and got an email that I thought was from the commit closing the ticket, but it wasn't.
by , 19 years ago
| Attachment: | track_post_commit_hook.diff added |
|---|
Diff of a working fix to the current trunk version
by , 19 years ago
| Attachment: | track_post_commit_hook.2.diff added |
|---|
A working diff from the current trunk.
comment:11 by , 19 years ago
Attached a working patch, the last one doubled up a command line option, early morning.
by , 19 years ago
| Attachment: | trac-post-commit.patch added |
|---|
patch against current post-commit script, [1497]
comment:12 by , 19 years ago
tried the second diff that was posted, and it didn't apply cleanly to the current tree, so I took my current working ticket-emailer and added a few things:
- corrects the commented example to use -s instead of the incorrect -u for url
- pulls trac.ini project url in if no url is passed in via -s
- imho much simpler code, and in my case, it actually works.
comment:13 by , 19 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Applied to trunk, thanks!
What is the "SVN commit command 'refs'"?