Edgewall Software
Modify ↓

Opened 11 years ago

Closed 11 years ago

#11122 closed defect (fixed)

RTL for wiki-toc broken?

Reported by: Dirk Stöcker Owned by: Christian Boos
Priority: normal Milestone: 1.0.2
Component: general Version:
Severity: normal Keywords: css rtl
Cc: ryan.j.ollos@… Branch:
Release Notes:

The #!rtl CSS support now applies globally, not only in wiki pages.

API Changes:
Internal Changes:

Description

When I use PageOutline inside RTL the box appears on right side (newest firefox here). Shouldn't it be left (see #9406).

  1. Left
    1. Left2

Left

Left2

  1. Right 1
    1. Right 2

Right 1

RTL 1

Right 2

RTL 2

Attachments (0)

Change History (5)

comment:1 by Christian Boos, 11 years ago

Keywords: css added
Milestone: → 1.0.2
Owner: set to Christian Boos
Release Notes: modified (diff)
Status: new → assigned

With #9406, you're supposed to write: 

{{{
#!rtl
[[PageOutline]]
= Right 1 =

RTL 1

== Right 2 ==

RTL 2

}}}

  1. Right 1
    1. Right 2

Right 1

RTL 1

Right 2

RTL 2

Or at the very least: 

{{{
#!div dir="rtl" class="rtl"
[[PageOutline]]
= Right 1 =

RTL 1

== Right 2 ==

RTL 2

}}}

  1. Right 1
    1. Right 2

Right 1

RTL 1

Right 2

RTL 2

so that the .rtl div.wiki-toc CSS rule can apply.

However that rule is only in wiki.css, and should probably be moved into trac.css so that it could work in tickets as well.

Now the other issues with this specific example (.wiki-toc) is that .wiki-toc is also only in wiki.css. Here it looks "correct" because the ​TH:WikiExtrasPlugin overrides it (with float: right !important; so this would even override the .rtl .wiki-toc one). The joy of bringing together bits and pieces of CSS ;-)

comment:2 by Ryan J Ollos <ryan.j.ollos@…>, 11 years ago

Are we in need of some documentation for the rtl WikiProcessor? Am I overlooking its documentation somewhere, or is this some web common-knowledge that I haven't obtained yet ? :) I wasn't aware that it exists, and don't see a mention of it on the WikiProcessors page.

comment:3 by Ryan J Ollos <ryan.j.ollos@…>, 11 years ago

I've also recently discovered the table WikiProcessor (via ​th:#10832), and it looks like we need documentation on the WikiProcessors page for that one as well.

comment:4 by Ryan J Ollos <ryan.j.ollos@…>, 11 years ago

Cc: ryan.j.ollos@… added

comment:5 by Christian Boos, 11 years ago

Keywords: rtl added
Resolution: → fixed
Status: assigned → closed

Added a note to WikiProcessors and move the CSS from wiki.css to trac.css in r11757.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.