Edgewall Software
Modify

Opened 10 years ago

Closed 9 years ago

#9406 closed enhancement (fixed)

wiki-toc float value should be RTL-aware

Reported by: Itamar Ostricher Owned by: Itamar Ostricher
Priority: normal Milestone: 1.0
Component: wiki system Version: 0.12.2
Severity: normal Keywords: rtl
Cc: Branch:
Release Notes:

wiki: Added a #!rtl wiki processor to simplify the insertion of RTL text blocks.

API Changes:
Internal Changes:

Description

The TracGuide and TocMacro use the wiki-toc class for floating div.

When a page is right-to-left, the floating div should be floating left.

Assuming right-to-left pages are created using some top-level container of the form:

{{{
#!div class=rtl
...
}}}

The direction-aware float may be achieved with the attached rtl-css.patch patch.

Attachments (2)

rtl-css.patch (406 bytes ) - added by Itamar Ostricher 10 years ago.
Patch that introduces some RTL support to CSS
rtl-css-indent.patch (445 bytes ) - added by Itamar Ostricher 9 years ago.
RTL subtlety regarding indentation of wiki-toc floats

Download all attachments as: .zip

Change History (10)

by Itamar Ostricher, 10 years ago

Attachment: rtl-css.patch added

Patch that introduces some RTL support to CSS

comment:1 by Christian Boos, 10 years ago

Milestone: 0.13
Owner: set to Itamar Ostricher

Thanks for the patch!

comment:2 by Itamar Ostricher, 10 years ago

See also the DirClassMacro I published on t-h.org.

It adds the CSS suggested in this patch, and also introduces [[RTL]] and [[LTR]] macros that emit right-aligned div tags and closing tags, respectively.

This even interacts correctly with TracWysiwygPlugin, which had a problem with aligned-div-tags as suggested in the ticket description.

A possible issue I've noticed is that if I use [[RTL]] with no matching [[LTR]], and I edit in side-by-side mode, then just after clicking Show Preview the editing area and action buttons either disappear completely or appear below the preview instead of to the side.

Anyway, I suggest to integrate the macro in core, as another step toward RTL-support.

in reply to:  2 comment:3 by Christian Boos, 10 years ago

Replying to itamaro:

Anyway, I suggest to integrate the macro in core, as another step toward RTL-support.

No, we don't want to support any macro that introduces non well-formed XHTML, i.e. begin a div in one macro, close it in another. The proper way to do this would be a #!rtl processor, but then I wonder if it adds more than a #!div class=rtl? It's still a bit more convenient to write, so we could support it anyway.

comment:4 by Remy Blank, 10 years ago

I have applied rtl-css.patch in [10547]. I'll also quicly implement a #!rtl processor for convenience.

comment:5 by Remy Blank, 10 years ago

Resolution: fixed
Status: newclosed

[10548] adds the #!rtl wiki processor.

comment:6 by Remy Blank, 10 years ago

Release Notes: modified (diff)

by Itamar Ostricher, 9 years ago

Attachment: rtl-css-indent.patch added

RTL subtlety regarding indentation of wiki-toc floats

comment:7 by Itamar Ostricher, 9 years ago

Resolution: fixed
Status: closedreopened
Version: 0.12dev0.12.2

Reopening the ticket in order to submit an additional patch that enhances the previous one, as far as the indentation of RTL-wiki-toc floats is concerned (see rtl-css-indent.patch)

comment:8 by Remy Blank, 9 years ago

Resolution: fixed
Status: reopenedclosed

Applied in [10736].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Itamar Ostricher.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Itamar Ostricher to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.