Edgewall Software
Modify

Opened 8 years ago

Closed 7 years ago

#11109 closed enhancement (fixed)

Functional test for Wiki History

Reported by: Ryan J Ollos <ryan.j.ollos@…> Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.2
Component: wiki system Version: 1.0-stable
Severity: normal Keywords: functional test
Cc: Branch:
Release Notes:

Added a functional test case for wiki history.

API Changes:

FunctionalTester.edit_wiki_page and FunctionalTester.create_wiki_page accept a comment parameter that defaults to a random sentence.

Internal Changes:

Description

Some work on a Trac theme/plugin broke the ability to navigate to the Wiki History, and I thought it would be good to put a functional test in place for Trac since there currently is none.

The patch will create and edit a wiki page, and then navigate to the Wiki History and checks for the correct content.

Attachments (0)

Change History (5)

comment:1 by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

I did some work in trac/tests/functional/tester.py on the branch for #11028 that I'd like to utilize for this patch. Will it work okay to branch from that ticket's branch (t10957.2) for doing the work in this ticket?

comment:2 by Christian Boos, 8 years ago

Milestone: next-stable-1.0.x

Yes, it's not a big deal in git to stack branches, if you can keep the overview (*).

I'm going to integrate that work on #11028 "soon", so when it's done you'll be able to rebase that branch on trunk.


(*) git log --graph --oneline --decorate --simplify-by-decoration helps ;-) I've aliases that to git topo, so I can do git topo --remotes=github-ryano and still have a good grasp of whatever tangled web of branches you come up with ;-)

comment:3 by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

  • 41eb9b5b: Provide a parameter to specify a comment in the call to FunctionalTester.edit_wiki_page, defaulting to a random sentence for the comment.
  • dccd58ed: Added a functional test for wiki history.
  • 4c9adfab: Refactored tests to utilize default for pagename parameter in create_wiki_page.

The branch is based on t10957.2 from ticket #11028. The branch needs to be rebased onto the mysteriously absent changes listed in #11028 (comment:14:ticket:11028) in order for the tests to pass. The test run currently fails because fbbf8305 is needed.

comment:4 by Ryan J Ollos, 7 years ago

Keywords: functional added
Milestone: next-stable-1.0.x1.0.2
Owner: set to Ryan J Ollos
Status: newassigned
Version: 1.0-stable

comment:5 by Ryan J Ollos, 7 years ago

API Changes: modified (diff)
Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed to 1.0-stable in [11888:11890], and merged to trunk in [11891].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.