Alignment of permissions in table on Admin Permissions panel

[Ryan J Ollos <ryan.j.ollos@…>]

Long permission names such as TICKET_EDIT_DESCRIPTION, TICKET_EDIT_COMMENT and some added by plugins disturb the nice alignment of the table.

So far, I don't have a great idea on how to improve this. The only idea I have is to truncate the permission name with ellipses and show the full name on hover (would the latter require JS to implement?).

[Ryan J Ollos <ryan.j.ollos@…>]

Replying to Ryan J Ollos <ryan.j.ollos@…>:

… (would the latter require JS to implement?).

Of course not! span with a title attribute should do the trick.

Here is an example with the text clipped, and the full permission name shown on hover-over:

I don't think the text-overflow: ellipses looks quite as good. It adds ellipses to text that wouldn't even be clipped (at least in Chromium 22).

A patch can be found in ​37791c7a.

The patch doesn't yet do quite what I was hoping for. I think it would be desirable to have a min-width for each column, but if there is only enough space for two columns at min-width, then the text should use all of the available space.

Specifically, this looks good, because there is just enough space in the table for 2 columns:

This does not, because there is almost enough space for 3 columns, but all of the available space isn't being used:

[Christian Boos]

For , that's the behavior we already have, so I think it's not a big deal.

But this is not i18n friendly:

title="${action + (' is no longer defined' if action not in actions else '')}"

[Ryan J Ollos <ryan.j.ollos@…>]

Replying to cboos:

But this is not i18n friendly:

title="${action + (' is no longer defined' if action not in actions else '')}"

Ah, right. I should know better! I'll fix that on the branch.

[Ryan J Ollos <ryan.j.ollos@…>]

Replying to cboos:

But this is not i18n friendly:

title="${action + (' is no longer defined' if action not in actions else '')}"

Is this correct and optimal?:

title="${_('%(action)s is no longer defined', action=action) if action not in actions else action}">

I'm assuming that action doesn't get translated, and therefore there is only one translatable string in the expression.

Also, the text-overlow: ellipsis looks better if the right padding is removed, so I feel this is best of the examples shown so far:

[Ryan J Ollos <ryan.j.ollos@…>]

I went ahead and pushed the comment:5 changes in ​4663842b (Removed right padding. Added text-overflow: ellipsis) and ​f9086fa1 (Fixed: title string was not i18n translatable). I'm still unsure that I fixed the latter correctly, but I'll try to revisit the issue soon and will follow up quickly if any additional changes are needed.

[Christian Boos]

Thanks! Applied the three changes in r11719.

The translation of the title works as expected, I tested it with the french translation.

[Ryan J Ollos]

I was seeing a conflict while trying to merge the work from #11069 to the trunk because [11719] was not yet merged. [11719] merged to trunk in [12035].

[Ryan J Ollos]

Regression fixed and regression test added in [12160].