#11094 closed enhancement (fixed)
Replace `tt` tags with `code` tags
Reported by: | Owned by: | Ryan J Ollos | |
---|---|---|---|
Priority: | normal | Milestone: | 1.1.2 |
Component: | general | Version: | |
Severity: | normal | Keywords: | html5 |
Cc: | Branch: | ||
Release Notes: |
Replaced HTML |
||
API Changes: | |||
Internal Changes: |
Description
If appropriate at this time, I'd like to generate a patch to replace the tt tags (not supported in HTML5) with code
tags. The CSS used for tt
tags should be left in place (for plugins), and also applied to the code
tags. A number of unit tests would need to be updated.
This seems like a good change to make for forward compatibility (and helps us clean up some things down the road for bh:#420). However, I'm not very familiar with HTML5, so I ask, are there any compatibility issues with making this change now?
Attachments (0)
Change History (5)
comment:1 by , 12 years ago
comment:2 by , 12 years ago
Milestone: | → next-dev-1.1.x |
---|---|
Owner: | set to |
Status: | new → assigned |
Too bad that <tt> is gone, as it's not always about "code".
comment:3 by , 11 years ago
Keywords: | html5 added |
---|---|
Milestone: | next-dev-1.1.x → 1.1.2 |
Owner: | changed from | to
Changes rebased in rjollos.git:t11094.
comment:4 by , 11 years ago
Release Notes: | modified (diff) |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
Committed to trunk in [11993].
There are
code
tags being used in the code-base already, but there is no Trac styling defined for them. For example, the default values in the TracIni tables, such as TracIni#git-section, are wrapped incode
tags. Here is an example of how they render:false
7a591648 is a patch to replace all usages of
tt
tags withcode
tags, and add styling forcode
tags. The unit and functional tests pass after these changes, however I'm having trouble getting the dependencies forlxml
installed on my system, so I haven't done a test run that exercises the tests with that dependency. I've also encountered the problem in #10722, so I'm not running the SVN tests atm.Maybe use
code
tags, nottt
tags would even be a recommendation to add to the proposed CSS usage chapter of the ApiDocs (comment:3:ticket:11084)?