Edgewall Software
Modify

Opened 7 years ago

Closed 6 years ago

Last modified 4 years ago

#11094 closed enhancement (fixed)

Replace `tt` tags with `code` tags

Reported by: Ryan J Ollos <ryan.j.ollos@…> Owned by: Ryan J Ollos
Priority: normal Milestone: 1.1.2
Component: general Version:
Severity: normal Keywords: html5
Cc: Branch:
Release Notes:

Replaced HTML tt tags with code tags.

API Changes:

Description

If appropriate at this time, I'd like to generate a patch to replace the tt tags (not supported in HTML5) with code tags. The CSS used for tt tags should be left in place (for plugins), and also applied to the code tags. A number of unit tests would need to be updated.

This seems like a good change to make for forward compatibility (and helps us clean up some things down the road for bh:#420). However, I'm not very familiar with HTML5, so I ask, are there any compatibility issues with making this change now?

Attachments (0)

Change History (5)

comment:1 by Ryan J Ollos <ryan.j.ollos@…>, 7 years ago

There are code tags being used in the code-base already, but there is no Trac styling defined for them. For example, the default values in the TracIni tables, such as TracIni#git-section, are wrapped in code tags. Here is an example of how they render:

  • <code>false</code> renders as: false
  • <tt>false</tt> renders as: false

7a591648 is a patch to replace all usages of tt tags with code tags, and add styling for code tags. The unit and functional tests pass after these changes, however I'm having trouble getting the dependencies for lxml installed on my system, so I haven't done a test run that exercises the tests with that dependency. I've also encountered the problem in #10722, so I'm not running the SVN tests atm.

Maybe use code tags, not tt tags would even be a recommendation to add to the proposed CSS usage chapter of the ApiDocs (comment:3:ticket:11084)?

comment:2 by Christian Boos, 7 years ago

Milestone: next-dev-1.1.x
Owner: set to Christian Boos
Status: newassigned

Too bad that <tt> is gone, as it's not always about "code".

comment:3 by Ryan J Ollos, 6 years ago

Keywords: html5 added
Milestone: next-dev-1.1.x1.1.2
Owner: changed from Christian Boos to Ryan J Ollos

Changes rebased in rjollos.git:t11094.

comment:4 by Ryan J Ollos, 6 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed to trunk in [11993].

comment:5 by Ryan J Ollos, 4 years ago

Additional changes in [14167].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.