Edgewall Software
Modify

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#11075 closed defect (fixed)

Git changesets with same revision should be a single event in timeline view

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.0.2
Component: plugin/git Version: 1.0
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Fix duplicated same changesets between git repositories in timeline view.

API Changes:
Internal Changes:

Description

Because GitRepository.get_changeset_uid is not implemented…

  • tracopt/versioncontrol/git/git_fs.py

    diff --git a/tracopt/versioncontrol/git/git_fs.py b/tracopt/versioncontrol/git/git_fs.py
    index 3802d7f..12b167e 100644
    a b class GitRepository(Repository):  
    434434        """GitChangeset factory method"""
    435435        return GitChangeset(self, rev)
    436436
     437    def get_changeset_uid(self, rev):
     438        return self.normalize_rev(rev)
     439
    437440    def get_changes(self, old_path, old_rev, new_path, new_rev,
    438441                    ignore_ancestry=0):
    439442        # TODO: handle renames/copies, ignore_ancestry

Attachments (0)

Change History (3)

comment:1 by Christian Boos, 8 years ago

Milestone: next-stable-1.0.x1.0.2

Oops… sure. Please commit!

(and if there's a patch, a branch, or anything meaning the thing is already well in progress, you should assign it to yourself, so it shows up as "yellow" in the milestone progress bar)

in reply to:  1 comment:2 by Jun Omae, 8 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: newclosed

Committed in [11706-11707].

(…, you should assign it to yourself, so it shows up as "yellow" in the milestone progress bar)

Sure. Thanks.

comment:3 by Ryan J Ollos <ryan.j.ollos@…>, 7 years ago

Owner: set to Jun Omae

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.