Edgewall Software

Opened 9 years ago

Closed 8 years ago

#11074 closed defect (fixed)

[revisionlog] graph_colors has wrong value on initenv

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.0.2
Component: general Version: 1.0
Severity: normal Keywords: config
Cc: Branch:
Release Notes:

Fix generating wrong values for ListOption in trac.ini and trac.ini.sample on Trac environment creation, e.g. [revisionlog] graph_colors.

API Changes:
Internal Changes:


Confguration class generates wrong value in trac.ini for ListOption which has raw list as the default value if the value for option is not specified.

Such a option is only [revisionlog] graph_colors in Trac. The revision graph has been drawn with only black color….

$ ~/venv/trac/1.0/bin/trac-admin /tmp/trac-1.0 initenv Project sqlite:db/trac.db >/dev/null
$ grep graph_colors /tmp/trac-1.0/conf/trac.ini
graph_colors = ['#cc0', '#0c0', '#0cc', '#00c', '#c0c', '#c00']

Attachments (0)

Change History (5)

comment:1 by Christian Boos, 9 years ago

In repos:jomae.git:ticket11074.

Looks good! Ideally we should try to recover the value of the sep… (we probably need to go directly through the Option.get_registry() instead of using defaults).

comment:2 by Jun Omae, 9 years ago

Owner: set to Jun Omae
Status: newassigned

Ok. In [716f7144/jomae.git], uses Option.get_registry() instead of self.defaults().

Also, minor issue, when section name has unicode characters and option is inherited, Configuration doesn't generate # name = <inherited>. Fix in [7dd3694f/jomae.git].


comment:3 by Jun Omae, 9 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed in [11767].

comment:4 by Jun Omae, 8 years ago

Resolution: fixed
Status: closedreopened

I've noticed the same issue is in trac.ini.sample in comment:4:ticket:11520.

$ grep colors conf/trac.ini.sample
graph_colors = ['#cc0', '#0c0', '#0cc', '#00c', '#c0c', '#c00']

comment:5 by Jun Omae, 8 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: reopenedclosed

Fixed in [12554] and merged to trunk in [12555].

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.