[revisionlog] graph_colors has wrong value on initenv

[Jun Omae]

Confguration class generates wrong value in trac.ini for ListOption which has raw list as the default value if the value for option is not specified.

Such a option is only [revisionlog] graph_colors in Trac. The revision graph has been drawn with only black color….

$ ~/venv/trac/1.0/bin/trac-admin /tmp/trac-1.0 initenv Project sqlite:db/trac.db >/dev/null
$ grep graph_colors /tmp/trac-1.0/conf/trac.ini
graph_colors = ['#cc0', '#0c0', '#0cc', '#00c', '#c0c', '#c00']

[Christian Boos]

In repos:jomae.git:ticket11074.

Looks good! Ideally we should try to recover the value of the sep… (we probably need to go directly through the Option.get_registry() instead of using defaults).

[Jun Omae]

Ok. In [716f7144/jomae.git], uses Option.get_registry() instead of self.defaults().

Also, minor issue, when section name has unicode characters and option is inherited, Configuration doesn't generate # name = <inherited>. Fix in [7dd3694f/jomae.git].

log:jomae.git:ticket11074.

[Jun Omae]

Committed in [11767].

[Jun Omae]

I've noticed the same issue is in trac.ini.sample in comment:4:ticket:11520.

$ grep colors conf/trac.ini.sample
graph_colors = ['#cc0', '#0c0', '#0cc', '#00c', '#c0c', '#c00']

[Jun Omae]

Fixed in [12554] and merged to trunk in [12555].