Edgewall Software

Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#11074 closed defect (fixed)

[revisionlog] graph_colors has wrong value on initenv — at Version 3

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.0.2
Component: general Version: 1.0
Severity: normal Keywords: config
Cc: Branch:
Release Notes:

Fixed generating wrong values for ListOption, e.g. [revisionlog] graph_colors, when creating new Trac environment

API Changes:
Internal Changes:

Description

Confguration class generates wrong value in trac.ini for ListOption which has raw list as the default value if the value for option is not specified.

Such a option is only [revisionlog] graph_colors in Trac. The revision graph has been drawn with only black color….

$ ~/venv/trac/1.0/bin/trac-admin /tmp/trac-1.0 initenv Project sqlite:db/trac.db >/dev/null
$ grep graph_colors /tmp/trac-1.0/conf/trac.ini
graph_colors = ['#cc0', '#0c0', '#0cc', '#00c', '#c0c', '#c00']

Change History (3)

comment:1 by Christian Boos, 11 years ago

In repos:jomae.git:ticket11074.

Looks good! Ideally we should try to recover the value of the sep… (we probably need to go directly through the Option.get_registry() instead of using defaults).

comment:2 by Jun Omae, 11 years ago

Owner: set to Jun Omae
Status: newassigned

Ok. In [716f7144/jomae.git], uses Option.get_registry() instead of self.defaults().

Also, minor issue, when section name has unicode characters and option is inherited, Configuration doesn't generate # name = <inherited>. Fix in [7dd3694f/jomae.git].

log:jomae.git:ticket11074.

comment:3 by Jun Omae, 11 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed in [11767].

Note: See TracTickets for help on using tickets.