Edgewall Software
Modify

Opened 7 years ago

Last modified 3 years ago

#11046 new defect

Reloading a page in the source browser redirects to another file

Reported by: noamtm@… Owned by:
Priority: normal Milestone: next-stable-1.2.x
Component: version control/browser Version: 1.0
Severity: normal Keywords: macosx
Cc: Branch:
Release Notes:
API Changes:

Description

It's hard to explain this one, so I'll jump directly to the steps to reproduce:

  1. Go to http://trac.edgewall.org/browser/trunk/trac
  2. Click a non-link area on the page
  3. Hover the "admin" directory
  4. Reload the page using the web browser's keyboard shortcut (ctrl-r or cmd-r)
  5. Browser navigates to http://trac.edgewall.org/browser/trunk/trac#admin

Keep hovering and reloading, it will navigate to files and folders.

Since this behavior is not documented (or is it?), and I find it annoying, I assume it's a bug.

My site is running v1.0, hence the report below. For some reason I can't find the version number of YOUR site.

Attachments (0)

Change History (8)

comment:1 by Remy Blank, 7 years ago

Which browser are you using? I can't reproduce with Firefox, Chrome or Opera. But maybe I'm misunderstanding step 2 above. Where exactly do you click?

comment:2 by anonymous, 7 years ago

I tested on Firefox, Chrome, Safari - on OSX. Just to make sure it also happens on IE, I switched to Windows. It does not show itself on any browser on Windows. Same for Firefox/OSX — when using F5 to refresh instead of cmd-r.

To recap: this bug seems to only happen on OSX, when refreshing the page using cmd-r. I'm not a JavaScript expert though, so can someone with a Mac take a look? I suspect it has something to do with the cmd key.

in reply to:  2 comment:3 by Noam Tamim <noamtm@…>, 7 years ago

Sorry, anonymous in comment 2 is me, the reporter.

comment:4 by Remy Blank, 7 years ago

Keywords: osx added
Milestone: 1.0.2
Owner: set to Remy Blank
Status: newassigned

Heh, I didn't know we had that :) Reproduced on a Mac. And it's even documented.

In the source browser, you can move the line selection cursor with j and k, and reload a folder with r (and if the folder wasn't open, it is opened). For some reason, cmd-r triggers the same action as r, and hence opens the folder where the cursor is located. If no cursor has been moved beforehand, it opens the folder pointed by the mouse cursor.

This is done in trunk/trac/htdocs/js/keyboard_nav.js. There's a check at the top for the Ctrl key, to allow Ctrl+R to work. We should improve that check to also catch the cmd key. According to some sources, the .metaKey event attribute can be used for this. Actually, for good measure, we should probably catch all modifiers there.

comment:5 by Ryan J Ollos, 6 years ago

Milestone: 1.0.21.0.3

comment:6 by Ryan J Ollos, 5 years ago

Milestone: 1.0.3next-stable-1.0.x
Owner: Remy Blank removed
Status: assignednew

comment:7 by Ryan J Ollos, 5 years ago

Keywords: macosx added; osx removed

comment:8 by Ryan J Ollos, 3 years ago

Milestone: next-stable-1.0.xnext-stable-1.2.x

Moved ticket assigned to next-stable-1.0.x since maintenance of 1.0.x is coming to a close. Please move the ticket back if it's critical to fix on 1.0.x.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned. Next status will be 'new'.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.