Edgewall Software
Modify

Opened 7 years ago

Closed 4 months ago

#11002 closed defect (fixed)

No To: headers

Reported by: Dan Jidanni Jacobson <jidanni@…> Owned by: Jun Omae
Priority: normal Milestone: 1.2.5
Component: notification Version:
Severity: minor Keywords: cc ticket
Cc: Branch:
Release Notes:

List owner, reporter and updater of the ticket in To header, when [notification] use_public_cc option is enabled.

API Changes:

Description

Can you believe creating a bug here doesn't even generate a basic To: header?! Spam trackers nail them.

Attachments (1)

ee (2.7 KB ) - added by Dan Jidanni Jacobson <jidanni@…> 7 years ago.
Mail message

Download all attachments as: .zip

Change History (12)

by Dan Jidanni Jacobson <jidanni@…>, 7 years ago

Attachment: ee added

Mail message

in reply to:  description comment:1 by Dan Jidanni Jacobson <jidanni@…>, 7 years ago

Spam trackers nail such defective mails.

comment:2 by Christian Boos, 7 years ago

Component: generalnotification
Keywords: cc added
Milestone: next-major-releases
Severity: trivialminor

I just checked how other bugtrackers do this… Indeed Mantis for example put everyone in the To: header.

As long as we have Add to Cc:, it seems a bit odd to not add one to the Cc:

comment:3 by Peter Suter, 3 years ago

We always have a undisclosed-recipients: ; To: header now. Does that resolve this ticket?

Last edited 3 years ago by Peter Suter (previous) (diff)

comment:4 by jidanni@…, 3 years ago

Sounds like it would.

comment:5 by Peter Suter, 3 years ago

Milestone: next-major-releases
Resolution: worksforme
Status: newclosed

Thanks for confirming. Closing ticket.

For anyone wondering: undisclosed-recipients: ; is an empty "group address" with display name "undisclosed-recipients". See rfc:5322#section-3.4, rfc:5322#appendix-A.1.3:

Because the list of mailboxes can be empty, using the group construct is also a simple way to communicate to recipients that the message was sent to one or more named sets of recipients, without actually providing the individual mailbox address for any of those recipients.

Seems we got that in changeset:13454 via th:AnnouncerPlugin from th:changeset:7655.

Before that Trac only sometimes used a To: header, depending on if ticket owner or reporter were notified, and on the use_public_cc configuration option.

in reply to:  5 ; comment:6 by Jun Omae, 9 months ago

Keywords: ticket added
Milestone: 1.2.4
Priority: lowestnormal
Resolution: worksforme
Status: closedreopened

Replying to Peter Suter:

Before that Trac only sometimes used a To: header, depending on if ticket owner or reporter were notified, and on the use_public_cc configuration option.

I consider we should keep the behavior also since 1.2.x.

I'm using AnnouncerPlugin on Trac 1.0.x in production environment. I've thought a user takes no mind even if the address is listed in which of to/cc header. However, I've received inquiry about the behavior and the user wanted to list address of the user in To header. I guess that the user receives all ticket and is using filter "my address is contained in To header" to catch owned tickets in mail user agent.

Proposed changes in [cd93cf992/jomae.git] (jomae.git@t11002).

Last edited 9 months ago by Jun Omae (previous) (diff)

in reply to:  6 comment:7 by Jun Omae, 9 months ago

Owner: set to Jun Omae
Status: reopenedassigned

Proposed changes in [cd93cf992/jomae.git] (jomae.git@t11002).

Added unit tests for RecipientMatcher in [8f1800c61/jomae.git].

comment:8 by Ryan J Ollos, 5 months ago

Milestone: 1.2.41.2.5

comment:9 by Ryan J Ollos, 4 months ago

The changes look good to me. Would you like to include in 1.2.5?

comment:10 by Jun Omae, 4 months ago

Yeah. I'd like to push the branch.

comment:11 by Jun Omae, 4 months ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed in [17079] and merged in [17080].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Jun Omae to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.