Edgewall Software
Modify

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#10995 closed defect (fixed)

Missing line break on the admin component edit page

Reported by: Ryan J Ollos <ryan.j.ollos@…> Owned by: Ryan J Ollos <ryan.j.ollos@…>
Priority: normal Milestone: 1.0.1
Component: general Version: 1.1.1dev
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Added missing line break after the Owner label on the Component edit admin panel.

API Changes:
Internal Changes:

Description

The layout of the component edit page is inconsistent relative to other admin edit pages. The component, milestone and version pages are shown below. For consistency, there should be a line break after Owner: on the component edit page.

.

Attachments (9)

AdminComponentEdit.png (20.0 KB ) - added by Ryan J Ollos <ryan.j.ollos@…> 8 years ago.
AdminMilestoneEdit.png (24.8 KB ) - added by Ryan J Ollos <ryan.j.ollos@…> 8 years ago.
AdminVersionEdit.png (21.3 KB ) - added by Ryan J Ollos <ryan.j.ollos@…> 8 years ago.
t10995-r11483-1.patch (574 bytes ) - added by Ryan J Ollos <ryan.j.ollos@…> 8 years ago.
Patch against r11483 of the trunk.
AdminComponentEdit-AfterPatch.png (20.1 KB ) - added by Ryan J Ollos <ryan.j.ollos@…> 8 years ago.
t10995-r11483-2.patch (595 bytes ) - added by Ryan J Ollos <ryan.j.ollos@…> 8 years ago.
Patch against r11483 of the trunk.
t10995-r11483-3.patch (601 bytes ) - added by Ryan J Ollos <ryan.j.ollos@…> 8 years ago.
Patch against r11483 of the trunk.
t10995-r11483-4.patch (1.4 KB ) - added by Ryan J Ollos <ryan.j.ollos@…> 8 years ago.
Patch against r11483 of the trunk.
t10995-r11483-5.patch (4.5 KB ) - added by Ryan J Ollos <ryan.j.ollos@…> 8 years ago.
Patch against r11483 of the trunk that sets max line width to 79 characters.

Download all attachments as: .zip

Change History (18)

by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

Attachment: AdminComponentEdit.png added

by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

Attachment: AdminMilestoneEdit.png added

by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

Attachment: AdminVersionEdit.png added

by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

Attachment: t10995-r11483-1.patch added

Patch against r11483 of the trunk.

by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

comment:1 by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

comment:2 by Remy Blank, 8 years ago

Milestone: 1.0.1

Thanks for the patch. Note that the owner_field() is used twice in the template, and one requires the <br/> while the other doesn't. So the patch will be slightly more complicated.

comment:3 by Remy Blank, 8 years ago

Owner: set to Remy Blank
Status: newassigned

by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

Attachment: t10995-r11483-2.patch added

Patch against r11483 of the trunk.

by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

Attachment: t10995-r11483-3.patch added

Patch against r11483 of the trunk.

by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

Attachment: t10995-r11483-4.patch added

Patch against r11483 of the trunk.

by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

Attachment: t10995-r11483-5.patch added

Patch against r11483 of the trunk that sets max line width to 79 characters.

comment:4 by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

Thanks, I took another crack at it in t10995-r11483-3.patch. Component.select returns None if owner is an empty string, so default_owner will only be an empty string when owner_field is called with no arguments.

I think the logic would be less confusing if select returned an empty string for Component.owner (rather than None) and the default argument to owner_field could then be None, but I doubt we want to make changes like that which could have other consequences.

t10995-r11483-4.patch also fixes two PEP8 violations. Finally, I've wondered why the max 79 character line length coding guideline doesn't seem to be enforced for templates. I modified this template to meet the guideline in t10995-r11483-5.patch and it seems nice and readable.

comment:5 by Remy Blank, 8 years ago

Resolution: fixed
Status: assignedclosed

I used a more explicit approach in [11495], by passing an additional br_after_label argument.

We don't particularly limit the line length of templates to 79 characters, as long as the file is readable, so I didn't apply patch -5.

comment:6 by Remy Blank, 8 years ago

Owner: changed from Remy Blank to Ryan J Ollos <ryan.j.ollos@…>

comment:7 by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

Release Notes: modified (diff)

comment:8 by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

Release Notes: modified (diff)

in reply to:  5 comment:9 by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

Replying to rblank:

I used a more explicit approach in [11495], by passing an additional br_after_label argument.

That makes sense; it is consistent with [11164#file7] and much more clear than my patch. The argument could even be changed from br_after_label to multiline for consistency across the template code.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos <ryan.j.ollos@…>.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos <ryan.j.ollos@…> to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.