'socket.error' object has no attribute 'strerror' on Python 2.5

[Jun Omae]

If tracd on Python 2.5 starts with a used port number, it crashes with the following error.

Error starting Trac server on 0.0.0.0:3000 view at http://127.0.0.1:3000/
Traceback (most recent call last):
  File "/home/jun66j5/venv/trac/1.0/bin/tracd", line 9, in <module>
    load_entry_point('Trac==1.0', 'console_scripts', 'tracd')()
  File "home/jun66j5/venv/trac/1.0/lib/python2.5/site-packages/trac/web/standalone.py", line 335, in main
  File "home/jun66j5/venv/trac/1.0/lib/python2.5/site-packages/trac/web/standalone.py", line 301, in serve
AttributeError: 'error' object has no attribute 'strerror'

socket.error on Python 2.6+ has an attribute strerror, however, not on Python 2.5 yet. ​http://docs.python.org/2/library/socket.html#socket.error

trac/web/standalone.py

@@ -298 +298 @@
                                        use_http_11=options.http11)
             except socket.error, e:
                 print 'Error starting Trac server on %s' % loc
-                print e.strerror
+                print e.args[1]
                 sys.exit(1)
 
             print 'Server starting in PID %i.' % os.getpid()

[Remy Blank]

Jun, don't hesitate to commit such fixes directly. The ticket is nice for documentation.

[Jun Omae]

Fixed in [11471-11472].