Edgewall Software
Modify

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#10743 closed enhancement (fixed)

Show number of attachments next to attachment heading on wiki page

Reported by: Ryan J Ollos <ryano@…> Owned by: Ryan J Ollos <ryano@…>
Priority: normal Milestone: 1.0
Component: attachment Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Show number of attachments in section title

API Changes:

Description

As originally discussed in comment:35:ticket:8295:

Since the attachments on a wiki page are hidden in a collapsed section when the page is initially loaded, it would be useful to show the number of attachments next to the heading, e.g. Attachments (6). Without this, there is no immediate way to see that the page has attachments.

This may also be useful to show on the Ticket page, though it seems less important in that case since the attachments section is initially expanded.

Attachments (6)

TicketPage.png (17.5 KB ) - added by Ryan J Ollos <ryano@…> 7 years ago.
WikiPage.png (17.3 KB ) - added by Ryan J Ollos <ryano@…> 7 years ago.
AttachmentPage.png (12.2 KB ) - added by Ryan J Ollos <ryano@…> 7 years ago.
t10743-r11098-1.patch (1.1 KB ) - added by Ryan J Ollos <ryano@…> 7 years ago.
AttachmentSectionInitiallyCollapsed.png (31.3 KB ) - added by Ryan J Ollos <ryano@…> 7 years ago.
t10743-r11100-1.patch (1.9 KB ) - added by Ryan J Ollos <ryano@…> 7 years ago.
Trivial change from previous patch - Ticket's attachments section is now initially folded.

Download all attachments as: .zip

Change History (18)

by Ryan J Ollos <ryano@…>, 7 years ago

Attachment: TicketPage.png added

by Ryan J Ollos <ryano@…>, 7 years ago

Attachment: WikiPage.png added

by Ryan J Ollos <ryano@…>, 7 years ago

Attachment: AttachmentPage.png added

comment:1 by Ryan J Ollos <ryano@…>, 7 years ago

Replying to Ryan J Ollos <ryano@…>:

Without this, there is no immediate way to see that the page has attachments.

I should have said, without this, there is no immediate way to see the number of attachments. Alternatively, we could just show the number of attachments when the foldable section is collapsed.

I'm on the fence as to whether this is a good idea, or all that useful. I thought I'd give the implementation a try anyway. See attached patch.



by Ryan J Ollos <ryano@…>, 7 years ago

Attachment: t10743-r11098-1.patch added

comment:2 by lkraav <leho@…>, 7 years ago

Probably a very good point. I today also noticed with my last comment:67:ticket:10012 upload that if i have "Comments only" checked, then I will have no indication of attachments being sent at all. Felt confusing. I'm pretty sure this is another thing related to the "we need a sidebar" proposal #10739. I guess a position:fixed header control panel of some sort is also an option, but sidebars are definitely more versatile.

in reply to:  description ; comment:3 by Christian Boos, 7 years ago

Replying to Ryan J Ollos <ryano@…>:

This may also be useful to show on the Ticket page, though it seems less important in that case since the attachments section is initially expanded.

… but this would enable us to have that section collapsed by default as well.

in reply to:  3 comment:4 by Ryan J Ollos <ryano@…>, 7 years ago

Replying to cboos:

… but this would enable us to have that section collapsed by default as well.

+1 from me, but there had previously been some reservation about making that change: comment:33:ticket:8295. Maybe you are less fearful of revolts? ;)

I also noted in comment:32:ticket:8295, that if we were to make the ticket attachments section folded by default, we might want to bring the attachment button outside of the foldable area. Thoughts?

by Ryan J Ollos <ryano@…>, 7 years ago

comment:5 by Ryan J Ollos <ryano@…>, 7 years ago

A couple of thoughts:

  • After staring at this for a while, it starts to look out of place that the Change History doesn't indicate the number of entries as well. Since that section is initially folded, maybe that is a feature we'd want as well?
  • Should the attachments quickjump at the bottom of the wiki page also cause a folded Attachments section to be unfolded?

by Ryan J Ollos <ryano@…>, 7 years ago

Attachment: t10743-r11100-1.patch added

Trivial change from previous patch - Ticket's attachments section is now initially folded.

in reply to:  5 ; comment:6 by Christian Boos, 7 years ago

  • After staring at this for a while, it starts to look out of place that the Change History doesn't indicate the number of entries as well. Since that section is initially folded, maybe that is a feature we'd want as well?

Yes, that was my reasoning as well.

  • Should the attachments quickjump at the bottom of the wiki page also cause a folded Attachments section to be unfolded?

Could be, yes. Note that I'm removing the "Modify" quick jump, but the one for the attachments (at the bottom of the page) doesn't get so in the way.

I'm toying with the idea of having a ticket view going like this:

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                       |
      |                                                       |
      |                                                       |
      '-------------------------------------------------------'

      > Attachments (2) [+]          [ Edit ] [x] Side-by-side

      > Change History

      Add a comment
      .-------------------------------------------------------.
      |                                                       |
      |                                                       |
      '-------------------------------------------------------'

      [ Preview ]   [ Edit ](*)                    [ Submit ]

(*) Maybe with a reprise of the edit button at the bottom.

(but I'm afraid I won't have the time to experiment with this until I'm back from holidays, 2nd week of July)

comment:7 by Christian Boos, 7 years ago

Milestone: 1.0

I have a few follow-ups on this (which in turn will be polished as part of #10012).

comment:9 by Christian Boos, 7 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: newclosed

Committed the above changesets in r11126, r11127 and r11128.

The last needed a bit of additional clean-up. I removed the whole onfocus stuff, I don't think it ever worked (at least it doesn't in 0.12.4dev either, e.g. here on Babel or demo-0.12).

in reply to:  6 ; comment:10 by Ryan J Ollos <ryano@…>, 7 years ago

Replying to cboos:

  • Should the attachments quickjump at the bottom of the wiki page also cause a folded Attachments section to be unfolded?

Could be, yes. Note that I'm removing the "Modify" quick jump, but the one for the attachments (at the bottom of the page) doesn't get so in the way.

Any further thoughts on whether this feature would be worthwhile? I've experimented with the latest trunk and thinking it could add some value. Perhaps as a patch in another ticket though.

The light font for the numbering is a nice touch!

in reply to:  10 comment:11 by Christian Boos, 7 years ago

Replying to Ryan J Ollos <ryano@…>:

Replying to cboos:

  • Should the attachments quickjump at the bottom of the wiki page also cause a folded Attachments section to be unfolded?

Could be, yes. Note that I'm removing the "Modify" quick jump, but the one for the attachments (at the bottom of the page) doesn't get so in the way.

Any further thoughts on whether this feature would be worthwhile? I've experimented with the latest trunk and thinking it could add some value.

I've tried to put the Attach button on the same line as the Attachments section, but it didn't look that good. When #10012 hits trunk (soon), I'll give it another try with a trac-quickbutton (+ Add). If this works, opening the attachments foldable wouldn't be that necessary but could still be nice (needs some experimentation).

comment:12 by Christian Boos, 7 years ago

Owner: set to Ryan J Ollos <ryano@…>

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos <ryano@…>.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.