Opened 13 years ago
Closed 13 years ago
#10680 closed defect (fixed)
System messages are visible on printed pages
Reported by: | Owned by: | Remy Blank | |
---|---|---|---|
Priority: | normal | Milestone: | 1.0 |
Component: | general | Version: | 0.12-stable |
Severity: | trivial | Keywords: | patch, review |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
After a successful operation, e.g. saving of a wiki page, a system message is displayed on top of the page.
For some reason, this message is still visible if the page is printed.
Consider the following scenario:
- The user is modifying or creating a wiki page, and wants to print it (or save as PDF) when done.
- Having clicked Save, the user prints the page.
- On the hard copy, the message "Your changes have been saved" is displayed.
Attachments (1)
Change History (3)
by , 13 years ago
Attachment: | ticket-10680-r1.diff added |
---|
comment:1 by , 13 years ago
Milestone: | → 0.12.4 |
---|---|
Owner: | set to |
This makes sense, thanks for the patch. I have also wanted to add a small "close" button at the top-right of those boxes for a long time (currently I simply reload the page), but that's independent.
comment:2 by , 13 years ago
Milestone: | 0.12.4 → 1.0 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
I have removed the warning and notice boxes from printing in [11055] (using their ID, though, because we use the .system-message
class in other contexts, e.g. errors due to wiki rendering).
And while I was at it, I added a small "[close]" link at the top-right of these boxes, to allow the user to hide them.
Patch against 0.12-stable fixing the defect