[PATCH] Unit test trac.db.util.sql_escape_percent()

[Alex Willmer <alex@…>]

The file source:trunk/trac/db/tests/util.py​ is a little spartan, here's a shot at improving that.

[Christian Boos]

Good idea! However, for the specifics of sql_escape_percent, I think a doctest could be more appropriate (as it'll also serve more directly as a kind of terse "documentation" for the function).

i.e.

def sql_escape_percent(x):
    """Escapes the percent character appropriately for SQL queries.
    
    Leave it unchanged as it be substituted:
    >>> [sql_escape_percent(x) for x in ["%", "''%''", ...]]
    ["%", "''%''", ...]

    Double it so that SQL interprets it literally :
    >>> [sql_escape_percent(x) for x in ["'%'", "'''%'''", ...]]
    ["'%%'", "'''%%'''", ...]
    """

(or something like that, untested code)

Look at some other tests (e.g. source:/trunk/trac/tests/resource.py​) to see how to add a DocTestSuite.

[Remy Blank]

Preparing for 1.0.

[Christian Boos]

Patch committed in r11094.

It was not that important to have a doctest for this one (it would even have been overly verbose, given the number of tests you had).

So… Thanks!