Edgewall Software

Opened 13 years ago

Closed 13 years ago

#10512 closed defect (fixed)

[PATCH] no warning if config option "repository_sync_per_request" is set incorrectly

Reported by: Andrew C Martin <andrew.c.martin@…> Owned by: Remy Blank
Priority: normal Milestone: 0.12.3
Component: version control Version: 0.12
Severity: minor Keywords: warning sync repository
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:


Consider this scenario:

New Trac 0.12 install, repository configured, everything working great. One week later, a Trac Admin decided to give the default repository a descriptive name via the web interface. Quietly, the repository synchronization stops working. No one notices for days.

It can be very difficult troubleshoot this without a warning message. The fact that both the repo's "name" and "type" can be "(default)" can confuse one into thinking that a misconfigured "repository_sync_per_request=(default)" refers to the repo's type. It took a bunch of new debug messages for me to figure out why my Trac was misbehaving.

So I propose attachment:repository_sync_per_request_warning.patch to help others diagnose this problem. It also improves the existing warnings in pre_process_request() by outputting "(default)" for the default reponame instead of an empty string.

Also, it'd be nice if the notices below also included a message about repository_sync_per_request. I wasn't familiar enough with this code to make that change.


  • Your changes have been saved.
  • You will need to update your post-commit hook to call trac-admin $ENV changeset added "NEW-REPO-NAME" $REV with the new repository name.

Attachments (1)

repository_sync_per_request_warning.patch (1.0 KB ) - added by Andrew C Martin <andrew.c.martin@…> 13 years ago.
proposed patch

Download all attachments as: .zip

Change History (3)

by Andrew C Martin <andrew.c.martin@…>, 13 years ago

proposed patch

comment:1 by Remy Blank, 13 years ago

Milestone: 0.12.3
Owner: set to Remy Blank

Good points.

comment:2 by Remy Blank, 13 years ago

Resolution: fixed
Status: newclosed

Slightly simpler patch applied in [10910].

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Remy Blank.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Remy Blank to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.