[PATCH] no warning if config option "repository_sync_per_request" is set incorrectly

[Andrew C Martin <andrew.c.martin@…>]

Consider this scenario:

New Trac 0.12 install, repository configured, everything working great. One week later, a Trac Admin decided to give the default repository a descriptive name via the web interface. Quietly, the repository synchronization stops working. No one notices for days.

It can be very difficult troubleshoot this without a warning message. The fact that both the repo's "name" and "type" can be "(default)" can confuse one into thinking that a misconfigured "repository_sync_per_request=(default)" refers to the repo's type. It took a bunch of new debug messages for me to figure out why my Trac was misbehaving.

So I propose attachment:repository_sync_per_request_warning.patch​ to help others diagnose this problem. It also improves the existing warnings in pre_process_request() by outputting "(default)" for the default reponame instead of an empty string.

Also, it'd be nice if the notices below also included a message about repository_sync_per_request. I wasn't familiar enough with this code to make that change.

source:trunk/trac/versioncontrol/admin.py#L233​:

• Your changes have been saved.
• You will need to update your post-commit hook to call trac-admin $ENV changeset added "NEW-REPO-NAME" $REV with the new repository name.

[Andrew C Martin <andrew.c.martin@…>]

proposed patch

[Remy Blank]

Good points.

[Remy Blank]

Slightly simpler patch applied in [10910].