Spam Filter Plugin Error: "UnboundLocalError: local variable 'blogspam' referenced before assignment"

[manuel.holtgrewe@…]

Setup

I installed the SpamFilter plugin (svn checkout, python setup.py bdist_egg) and installed it via upload in the Admin/Plugins section. My trac version is 0.12.2, I have revision 10882 of the 0.12 branch of the spam-filter-captcha plugin.

Error

To reproduce:

• enable the external service admin admin pane
• go to /admin/spamfilter/external
• uncheck "Use external services"
• click "Apply Changes".

You are now presented with an error message reading

Trac detected an internal error:
UnboundLocalError: local variable 'blogspam' referenced before assignment
This is probably a local installation issue.

The traceback is

File "/usr/lib/python2.6/dist-packages/trac/web/main.py", line 511, in _dispatch_request
  dispatcher.dispatch(req)
File "/usr/lib/python2.6/dist-packages/trac/web/main.py", line 237, in dispatch
  resp = chosen_handler.process_request(req)
File "/usr/lib/python2.6/dist-packages/trac/admin/web_ui.py", line 116, in process_request
  path_info)
File "build/bdist.linux-x86_64/egg/tracspamfilter/admin.py", line 381, in render_admin_panel
  'blogspam_methods': ", ".join(blogspam.getmethods()),

Suggested Fix

The following little patch should get rid of the problem.

Index: tracspamfilter/admin.py
===================================================================
--- tracspamfilter/admin.py	(revision 10886)
+++ tracspamfilter/admin.py	(working copy)
@@ -296,6 +296,7 @@
         typepad = TypePadFilterStrategy(self.env)
         akismet = AkismetFilterStrategy(self.env)
         stopforumspam = StopForumSpamFilterStrategy(self.env)
+        blogspam = BlogSpamFilterStrategy(self.env)
         defensio = 0
         if DefensioFilterStrategy:
             defensio = DefensioFilterStrategy(self.env)
@@ -351,7 +352,6 @@
             filtersys = FilterSystem(self.env)
             use_external = filtersys.use_external
             train_external = filtersys.train_external
-            blogspam = BlogSpamFilterStrategy(self.env)
             blogspam_api_url = blogspam.api_url
             blogspam_skip_tests = ",".join(blogspam.skip_tests)
             akismet_api_url = akismet.api_url

[Dirk Stöcker]

In r10887.