#10404 closed enhancement (fixed)
[PATCH] Missing column headers on About page
Reported by: | Thijs Triemstra | Owned by: | Thijs Triemstra |
---|---|---|---|
Priority: | normal | Milestone: | 1.0 |
Component: | general | Version: | 0.12-stable |
Severity: | minor | Keywords: | |
Cc: | Thijs Triemstra | Branch: | |
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
The 'System Information' and 'Installed Plugins' tables on the About page are missing column headers. For the System Information table it's clear what the columns mean, but for the plugins table it's confusing to see 'N/A' in the second column when you don't know what is normally supposed to be displayed there (digging into the template source reveals it's the version nr).
Attached patch adds column headings for both tables.
Attachments (2)
Change History (6)
by , 13 years ago
Attachment: | table-heading.patch added |
---|
comment:1 by , 13 years ago
Milestone: | → 0.13 |
---|---|
Owner: | set to |
by , 13 years ago
Attachment: | table-heading-2.patch added |
---|
comment:2 by , 13 years ago
Yes, that plus one level of indentation inside the <tbody>
(no need to post an updated patch, I'll do it). Thanks.
comment:3 by , 13 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Patch applied in [10975], together with the removal of the colon after "jQuery" and a bit of CSS tuning.
comment:4 by , 13 years ago
Owner: | changed from | to
---|
Why not. You should also wrap the table rows in a
<tbody>
, according to the HTML spec: