Edgewall Software
Modify

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#10404 closed enhancement (fixed)

[PATCH] Missing column headers on About page

Reported by: Thijs Triemstra Owned by: Thijs Triemstra
Priority: normal Milestone: 1.0
Component: general Version: 0.12-stable
Severity: minor Keywords:
Cc: Thijs Triemstra Branch:
Release Notes:
API Changes:

Description

The 'System Information' and 'Installed Plugins' tables on the About page are missing column headers. For the System Information table it's clear what the columns mean, but for the plugins table it's confusing to see 'N/A' in the second column when you don't know what is normally supposed to be displayed there (digging into the template source reveals it's the version nr).

Attached patch adds column headings for both tables.

Attachments (2)

table-heading.patch (1.2 KB ) - added by Thijs Triemstra 8 years ago.
table-heading-2.patch (1.4 KB ) - added by Thijs Triemstra 8 years ago.

Download all attachments as: .zip

Change History (6)

by Thijs Triemstra, 8 years ago

Attachment: table-heading.patch added

comment:1 by Remy Blank, 8 years ago

Milestone: 0.13
Owner: set to Remy Blank

Why not. You should also wrap the table rows in a <tbody>, according to the HTML spec:

The TBODY start tag is always required except when the table contains only one table body and no table head or foot sections.

by Thijs Triemstra, 8 years ago

Attachment: table-heading-2.patch added

comment:2 by Remy Blank, 8 years ago

Yes, that plus one level of indentation inside the <tbody> (no need to post an updated patch, I'll do it). Thanks.

comment:3 by Remy Blank, 8 years ago

Resolution: fixed
Status: newclosed

Patch applied in [10975], together with the removal of the colon after "jQuery" and a bit of CSS tuning.

comment:4 by Remy Blank, 8 years ago

Owner: changed from Remy Blank to Thijs Triemstra

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Thijs Triemstra.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Thijs Triemstra to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.