[patch] Intertrac link does not work for Image()

[Dirk Stöcker]

When I do an Intertrac link, for normal links it works correctly. For Image() this fails.

Link:

[[trac:source:/trunk/doc/images/bkgnd_pattern.png]]

source:/trunk/doc/images/bkgnd_pattern.png

Image:

[[Image(trac:source:/trunk/doc/images/bkgnd_pattern.png)]]

Supplying the resulting link directly works:

[[Image(http://trac.edgewall.org/browser/trunk/doc/images/bkgnd_pattern.png?format=raw)]]

The directly expanded link does not:

[[Image(http://trac.edgewall.org/intertrac/source:/trunk/doc/images/bkgnd_pattern.png?format=raw)]]

Probably the "?format=raw" is not correctly handled by the "intertrac/source:" URL?

[Dirk Stöcker]

Any progress with this?

[Dirk Stöcker]

A possible solution for this problem

[Dirk Stöcker]

I attached a patch, which can solve this issue and makes Image() links work when they have a "format=raw" attached.

[Christian Boos]

Thanks! Will try, test and apply if all goes well ;-)

[Christian Boos]

I don't like so much the idea of having to write:

[[Image(trac:source:/trunk/doc/images/bkgnd_pattern.png?format=raw)]]

because the following is not supposed to work either:

[[Image(source:/trunk/doc/images/bkgnd_pattern.png?format=raw)]]

I followed-up with some additional changes which make the following syntax work:

[[Image(trac:source:/trunk/doc/images/bkgnd_pattern.png)]]

[Christian Boos]

Fixed in [10894:10896].