#10196 closed defect (fixed)
[patch] Intertrac link does not work for Image()
| Reported by: | Dirk Stöcker | Owned by: | Dirk Stöcker |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.12.3 |
| Component: | rendering | Version: | 0.12-stable |
| Severity: | normal | Keywords: | intertrac patch |
| Cc: | Branch: | ||
| Release Notes: |
|
||
| API Changes: | |||
| Internal Changes: | |||
Description
When I do an Intertrac link, for normal links it works correctly. For Image() this fails.
Link:
[[trac:source:/trunk/doc/images/bkgnd_pattern.png]]
source:/trunk/doc/images/bkgnd_pattern.png
Image:
[[Image(trac:source:/trunk/doc/images/bkgnd_pattern.png)]]
Supplying the resulting link directly works:
[[Image(http://trac.edgewall.org/browser/trunk/doc/images/bkgnd_pattern.png?format=raw)]]
The directly expanded link does not:
[[Image(http://trac.edgewall.org/intertrac/source:/trunk/doc/images/bkgnd_pattern.png?format=raw)]]
Probably the "?format=raw" is not correctly handled by the "intertrac/source:" URL?
Attachments (1)
Change History (8)
comment:1 by , 13 years ago
| Keywords: | intertrac added |
|---|---|
| Milestone: | → next-minor-0.12.x |
comment:2 by , 13 years ago
comment:3 by , 13 years ago
| Keywords: | patch added |
|---|---|
| Summary: | Intertrac link does not work for Image() → [patch] Intertrac link does not work for Image() |
I attached a patch, which can solve this issue and makes Image() links work when they have a "format=raw" attached.
comment:4 by , 13 years ago
| Milestone: | next-minor-0.12.x → 0.12.3 |
|---|---|
| Owner: | set to |
Thanks! Will try, test and apply if all goes well ;-)
follow-up: 7 comment:5 by , 13 years ago
| Owner: | changed from to |
|---|
I don't like so much the idea of having to write:
[[Image(trac:source:/trunk/doc/images/bkgnd_pattern.png?format=raw)]]
because the following is not supposed to work either:
[[Image(source:/trunk/doc/images/bkgnd_pattern.png?format=raw)]]
I followed-up with some additional changes which make the following syntax work:
[[Image(trac:source:/trunk/doc/images/bkgnd_pattern.png)]]
comment:6 by , 13 years ago
| Release Notes: | modified (diff) |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Fixed in [10894:10896].
comment:7 by , 13 years ago
Replying to cboos:
I don't like so much the idea of having to write:
[[Image(trac:source:/trunk/doc/images/bkgnd_pattern.png?format=raw)]]
I didn't want to change too much at once. I was happy it worked at all :-)
Any progress with this?