Edgewall Software
Modify

Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#10196 closed defect (fixed)

[patch] Intertrac link does not work for Image()

Reported by: Dirk Stöcker Owned by: Dirk Stöcker
Priority: normal Milestone: 0.12.3
Component: rendering Version: 0.12-stable
Severity: normal Keywords: intertrac patch
Cc:
Release Notes:

[[Image()]] macro supports InterTrac source: links

API Changes:

Description

When I do an Intertrac link, for normal links it works correctly. For Image() this fails.

Link:

[[trac:source:/trunk/doc/images/bkgnd_pattern.png]]

source:/trunk/doc/images/bkgnd_pattern.png

Image:

[[Image(trac:source:/trunk/doc/images/bkgnd_pattern.png)]]

source:/trunk/doc/images/bkgnd_pattern.png in The Trac Project

Supplying the resulting link directly works:

[[Image(http://trac.edgewall.org/browser/trunk/doc/images/bkgnd_pattern.png?format=raw)]]

http://trac.edgewall.org/browser/trunk/doc/images/bkgnd_pattern.png

The directly expanded link does not:

[[Image(http://trac.edgewall.org/intertrac/source:/trunk/doc/images/bkgnd_pattern.png?format=raw)]]

http://trac.edgewall.org/intertrac/source:/trunk/doc/images/bkgnd_pattern.png

Probably the "?format=raw" is not correctly handled by the "intertrac/source:" URL?

Attachments (1)

intertrac.patch (1.7 KB ) - added by Dirk Stöcker 7 years ago.
A possible solution for this problem

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by Remy Blank

Keywords: intertrac added
Milestone: next-minor-0.12.x

comment:2 Changed 7 years ago by Dirk Stöcker

Any progress with this?

Changed 7 years ago by Dirk Stöcker

Attachment: intertrac.patch added

A possible solution for this problem

comment:3 Changed 7 years ago by Dirk Stöcker

Keywords: patch added
Summary: Intertrac link does not work for Image()[patch] Intertrac link does not work for Image()

I attached a patch, which can solve this issue and makes Image() links work when they have a "format=raw" attached.

comment:4 Changed 7 years ago by Christian Boos

Milestone: next-minor-0.12.x0.12.3
Owner: set to Christian Boos

Thanks! Will try, test and apply if all goes well ;-)

comment:5 Changed 7 years ago by Christian Boos

Owner: changed from Christian Boos to Dirk Stöcker

I don't like so much the idea of having to write:

[[Image(trac:source:/trunk/doc/images/bkgnd_pattern.png?format=raw)]]

because the following is not supposed to work either:

[[Image(source:/trunk/doc/images/bkgnd_pattern.png?format=raw)]]

I followed-up with some additional changes which make the following syntax work:

[[Image(trac:source:/trunk/doc/images/bkgnd_pattern.png)]]

comment:6 Changed 7 years ago by Christian Boos

Release Notes: modified (diff)
Resolution: fixed
Status: newclosed

Fixed in [10894:10896].

comment:7 in reply to:  5 Changed 7 years ago by Dirk Stöcker

Replying to cboos:

I don't like so much the idea of having to write:

[[Image(trac:source:/trunk/doc/images/bkgnd_pattern.png?format=raw)]]

I didn't want to change too much at once. I was happy it worked at all :-)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Dirk Stöcker.
The resolution will be deleted.
to The owner will be changed from Dirk Stöcker to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.