(almost patch) make browser quickjump dropdown context sensitive

[anonymous]

Hi, I made my quickjump context menu context sensitive because I have many many projects within the same erpository, and adding them all by hand to the trac.ini would not only be tedious, it would also confuse people since they probably only want to see available tags/branches to whatever server/program/library they are currently looking at.

I made a little patch to my trac 0.12.2 that does exactly what I want, but I guess to make it a full feature it should be configurable in some way (at lest switch it on/off, restrict it to some directory or all that match a pattern, or have some special keyword that gets substituted by the current path, or all at once).

Here are the changes:

versioncontrol/web_ui/browser.py

@@ -396 +397 @@
                                                                                                          
         quickjump_data = properties_data = None                                                          
         if node and not xhr:                                                                             
             properties_data = self.render_properties(                                                    
                     'browser', context, node.get_properties())                                           
-            quickjump_data = list(repos.get_quickjump_entries(rev))
+            quickjump_data = list(repos.get_quickjump_entries(rev,path))
 
         data = {
             'context': context, 'reponame': reponame, 'repos': repos,
             'repoinfo': all_repositories.get(reponame or ''),
             'path': path, 'rev': node and node.rev, 'stickyrev': rev,

versioncontrol/svn_fs.py

@@ -399 +399 @@
         self.repos = self.fs_ptr = self.pool = None                                       
                                                                                           
     def get_base(self):                                                                   
         return self.base                                                                  
                                                                                           
-    def _get_tags_or_branches(self, paths):                                               
+    def _get_tags_or_branches(self, paths, showpath = None):                              
         """Retrieve known branches or tags."""                                            
-        for path in self.params.get(paths, []):                                           
+       mypaths=self.params.get(paths,[])                                                  
+       if( showpath and showpath.startswith("trunk") ):                                   
+           npath=showpath.replace("trunk",paths)                                          
+           if( not npath.endswith("/") ):                                                 
+               npath += "/"                                                               
+           npath += "*"                                                                   
+           mypaths.append(npath)                                                          
+       for path in mypaths:                                                               
             if path.endswith('*'):                                                        
                 folder = posixpath.dirname(path)                                          
                 try:                                                                      
                     entries = [n for n in self.get_node(folder).get_entries()]            
                     for node in sorted(entries, key=lambda n:                             
@@ -418 +425 @@
                 try:                                                                      
                     yield self.get_node(path)                                             
                 except: # no right                                                        
                     pass                                                                  
                                                                                           
-    def get_quickjump_entries(self, rev):                                                 
+    def get_quickjump_entries(self, rev, showpath = None):                                
         """Retrieve known branches, as (name, id) pairs.                                  
                                                                                           
         Purposedly ignores `rev` and always takes the last revision.                      
         """                                                                               
-        for n in self._get_tags_or_branches('branches'):                                  
+        for n in self._get_tags_or_branches('branches',showpath):                         
             yield 'branches', n.path, n.path, None                                        
-        for n in self._get_tags_or_branches('tags'):                                      
+        for n in self._get_tags_or_branches('tags',showpath):                             
             yield 'tags', n.path, n.created_path, n.created_rev                           
                                                                                           
     def get_path_url(self, path, rev):                                                    
         url = self.params.get('url', '').rstrip('/')                                      
         if url:                    

This should give you an idea of what the feature looks like that I wanted to have.

[Christian Boos]

I fail to see what the patch does (or how it could work…showpath.replace("trunk", paths) where paths is a list?), so please provide us with an example instead.

I do see a few possible enhancements for the quickjump features though:

• switch the current path to what it looks below one of the listed branches / tags
• actually don't do a "go" but fill a field with the selected value, and have two buttons: |View| and |Diff| (the latter related to #9824)

[anonymous]

the patch assumes a structure of the svn like trunk/XXX/YYY and when you are looking at that in the browser, it automatically adds to the quickjump menu a list of things present in /branches/XXX/YYY/* and /tags/XXX/YYY/* so you can quickly jump to one of the tags/branches made out of the currently viewed trunk. Of course not everyone will have this struture or wants this feature, so to be a real feature it would need to be configureable.

[Christian Boos]

[OT] not sure what's going on in the description for the styling of the second file…