improper rendering of svn:externals when not configured

[anonymous]

Some people do not (or can not) configure all of their svn:external properties to really point to some ​http:// url. So when trac.ini has no svn:externals section the entry

foo svn://svnserver/path/to/whatever

will be just rendered as

• foo

and nothing else. This is pretty annoying, and I have modified my trac to display in that case the complete line from the externals entry, so if you are intrested, here is my _render_externals function (modified against 0.12.2)

trac/versioncontrol/svn_prop.py

@@ -71 +71 @@
                 continue
             localpath, rev, url = elements[0], '', elements[-1]
             if localpath.startswith('#'):
-                externals.append((external, None, None, None, None))
+                externals.append((external, None, None, None, None, None))
                 continue
             if len(elements) == 3:
                 rev = elements[1]
@@ -94 +94 @@
                 if prefix:
                     remotepath = posixpath.join(*reversed(prefix))
                 externals.append((localpath, revstr, base_url, remotepath,
-                                  href % {'path': remotepath, 'rev': rev}))
+                                  href % {'path': remotepath, 'rev': rev},
+                                  external))
             else:
-                externals.append((localpath, revstr, url, None, None))
+                externals.append((localpath, revstr, url, None, None,
+                                  external))
         externals_data = []
-        for localpath, rev, url, remotepath, href in externals:
+        for localpath, rev, url, remotepath, href, external in externals:
             label = localpath
             if url is None:
                 title = ''
@@ -108 +110 @@
                 label += rev + url
                 title = ''.join((remotepath, rev, url))
             else:
+                label = external
                 title = _('No svn:externals configured in trac.ini')
             externals_data.append((label, href, title))
         return tag.ul([tag.li(tag.a(label, href=href, title=title))

[Christian Boos]

All the tickets for {20} from last year have probably been seen multiple times by now, yet are still to be triaged…