Improper use of property() in env.py

[anonymous]

This code:

from trac.web.href import Href
from trac.env import open_environment

env = open_environment('/path/to/trac')
env.href = Href(u'https://example.com/trac/')

Creates this traceback:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: 'str' object is not callable

This is because of this line at ​http://trac.edgewall.org/browser//trunk/trac/env.py#L665

href = property(_get_href, 'The application root path')

The docs at ​http://docs.python.org/library/functions.html#property state that the doc string should be the fourth parameter, not the second parameter.

Same error on line 676 as well. All usages of property() should probably be checked.

[Remy Blank]

Yes, that's plain wrong. Thanks for the heads-up.

[Remy Blank]

Fixed in [10639].