Edgewall Software
Modify

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#10000 closed defect (fixed)

Diff of two revisions outside de root doesn't work

Reported by: Ismael de Esteban <ismael@…> Owned by:
Priority: normal Milestone: plugin - mercurial
Component: plugin/mercurial Version: 0.12dev
Severity: trivial Keywords: diff
Cc: Branch:
Release Notes:
API Changes:

Description

Seems that the path was wrongly taken, and had always the value of utf-8.

Attachments (1)

deep-diff-hg-fix.patch (673 bytes ) - added by Ismael de Esteban <ismael@…> 9 years ago.
I mistake sending the other one, this one is correct

Download all attachments as: .zip

Change History (8)

comment:1 by Ismael de Esteban <ismael@…>, 9 years ago

Attached a fix !!

by Ismael de Esteban <ismael@…>, 9 years ago

Attachment: deep-diff-hg-fix.patch added

I mistake sending the other one, this one is correct

comment:2 by Christian Boos, 9 years ago

Hm, can you please provide me with a small hg repository (or steps to create that repository) demonstrating the issue, as well as the exact operation you did, what you got and what you expected? Also, what is your [hg] encoding setting?

At first sight, I don't see what you'd gain from doing new_path.encode(self.encoding[0]) instead of self.to_s(new_path). The latter could even break if new_path can't be UTF-8 encoded. If UTF-8 encoding worked (by chance) but is not what you wanted because the path is actually in latin1, then you have to set your [hg] encoding accordingly, e.g.

[hg]
encoding = latin1

comment:3 by Christian Boos, 9 years ago

Oh, wait…

No, this is just a small bug with to_s, which I already fixed in my local version, yesterday evening. Will be present in the next changeset (together with many other changes…).

Forget everything about my request for a test repository, etc.

comment:4 by Remy Blank, 9 years ago

Ticket #10000… Congratulations! You win a complimentary Trac license :)

comment:5 by Christian Boos, 9 years ago

Milestone: plugin - mercurial
Resolution: fixed
Severity: majortrivial
Status: newclosed
Version: 0.12dev

Fixed part of r10496. Thanks for testing the brand new version of the plugin!

in reply to:  4 comment:6 by Christian Boos, 9 years ago

Replying to rblank:

Ticket #10000… Congratulations! You win a complimentary Trac license :)

Well, we can offer him a slot in the THANKS file! (not only for creating the 10000th ticket but also for r10153 ;-) ).

comment:7 by Ismael de Esteban <ismael.deesteban@…>, 9 years ago

Thanks :DD !!!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from (none) to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.