#10000 closed defect (fixed)
Diff of two revisions outside de root doesn't work
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | normal | Milestone: | plugin - mercurial |
| Component: | plugin/mercurial | Version: | 0.12dev |
| Severity: | trivial | Keywords: | diff |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
Seems that the path was wrongly taken, and had always the value of utf-8.
Attachments (1)
Change History (8)
comment:1 by , 13 years ago
by , 13 years ago
| Attachment: | deep-diff-hg-fix.patch added |
|---|
I mistake sending the other one, this one is correct
comment:2 by , 13 years ago
Hm, can you please provide me with a small hg repository (or steps to create that repository) demonstrating the issue, as well as the exact operation you did, what you got and what you expected? Also, what is your [hg] encoding setting?
At first sight, I don't see what you'd gain from doing new_path.encode(self.encoding[0]) instead of self.to_s(new_path). The latter could even break if new_path can't be UTF-8 encoded. If UTF-8 encoding worked (by chance) but is not what you wanted because the path is actually in latin1, then you have to set your [hg] encoding accordingly, e.g.
[hg] encoding = latin1
comment:3 by , 13 years ago
Oh, wait…
No, this is just a small bug with to_s, which I already fixed in my local version, yesterday evening. Will be present in the next changeset (together with many other changes…).
Forget everything about my request for a test repository, etc.
follow-up: 6 comment:4 by , 13 years ago
Ticket #10000… Congratulations! You win a complimentary Trac license :)
comment:5 by , 13 years ago
| Milestone: | → plugin - mercurial |
|---|---|
| Resolution: | → fixed |
| Severity: | major → trivial |
| Status: | new → closed |
| Version: | → 0.12dev |
Fixed part of r10496. Thanks for testing the brand new version of the plugin!
Attached a fix !!