Edgewall Software

Opened 13 years ago

Closed 13 years ago

Last modified 12 months ago

#9989 closed enhancement (fixed)

Threaded comments for ticket change history

Reported by: Christian Boos Owned by: Christian Boos
Priority: normal Milestone: 1.0
Component: ticket system Version: 0.13dev
Severity: normal Keywords: comment
Cc: Branch:
Release Notes:

Ticket comments can now be displayed threaded (requires javascript)

API Changes:
Internal Changes:


I was sure there was already a ticket for that… apparently not.

Anyway, the idea is not new. For tickets with a long and complicated history, a simple linear view of the change history can be difficult to follow. We have the follow-up/in reply to links, but that doesn't give an immediate visual representation of the structure, one has to click and follow the links.

Fortunately that "follow-up" information is all we need to re-organize the comments in a tree, using Javascript. The proposed UI for that is a "Threaded Comments" checkbox next to the Change History section.

When activated, changes are displayed like this:

illustrates [attachment:threaded-comments-r10450.patch]

Attachments (2)

Threaded Comments.png (40.6 KB ) - added by Christian Boos 13 years ago.
illustrates threaded-comments-r10450.patch
threaded-comments-r10450.patch (5.1 KB ) - added by Christian Boos 13 years ago.
ticket: threaded mode for change history.

Download all attachments as: .zip

Change History (6)

by Christian Boos, 13 years ago

Attachment: Threaded Comments.png added

by Christian Boos, 13 years ago

ticket: threaded mode for change history.

comment:1 by Christian Boos, 13 years ago

Resolution: fixed
Status: newclosed

Patch applied in [10510] (also, there I don't show the button if there's nothing to "thread").

It may be that one things or two remains to be improved, in which case we can add some notes here.

Also, an extension of this feature could be done in order to implement #3360.

comment:2 by Christian Boos, 13 years ago

Resolution: fixed
Status: closedreopened
Type: defectenhancement

Already noticed a few glitches:

  • the "inreply.png" arrow is also added to li.entry elements of embedded patches; apparently the CSS rule ul.children > li matches also for li entries not immediate children of ul.children, which I didn't expect from my limited understanding of CSS
  • the left border could be improved (e.g. 1px solid #eee)
  • the indent of the <li> elements could be a bit narrower ⇒ not found how to do it yet

As a side note:

Also, I've got trouble testing this at all in IE9, as an exception was thrown earlier from resizer.js:

var grip = $('<div class="trac-grip"/>').mousedown(beginDrag)[0];

(Object doesn't support this property or method thrown later in clone() in jquery.js - maybe a problem due to the recent switch to jQuery 1.5?). Hm. Actually there are lots of other problems with IE9. Strange, I didn't notice this when testing 1.5rc1. Right, this is http://bugs.jquery.com/ticket/8052.

in reply to:  2 comment:3 by Christian Boos, 13 years ago

Resolution: fixed
Status: reopenedclosed

… a few glitches:

All of these should be addressed in the follow-up changeset r10516.

comment:4 by Alex Willmer <al.willmer@…>, 12 years ago

Release Notes: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.