Edgewall Software
Modify ↓

Opened 20 years ago

Closed 20 years ago

#997 closed defect (fixed)

Posible leftover code in Changeset.py after [1103]

Reported by: Juanma Barranquero Owned by: Christopher Lenz
Priority: lowest Milestone: 0.9
Component: version control/changeset view Version: devel
Severity: trivial Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description (last modified by Christopher Lenz)

Is this fragment of Changeset.py after [1103] right? The last two lines seem a leftover of implementing apply_textdelta for classes HtmlDiffEditor and UnifiedDiffEditor. 

    def open_file(self, path, parent_baton, base_revision, file_pool):
        return [path, path, file_pool]

        if file_baton:
            self.print_diff(*file_baton)

Attachments (0)

Change History (2)

comment:1 by Christopher Lenz, 20 years ago

Description: modified (diff)
Milestone: → 0.9
Owner: changed from Jonas Borgström to Christopher Lenz
Status: new → assigned

Good catch. That code shouldn't be there anymore.

comment:2 by Christopher Lenz, 20 years ago

Resolution: → fixed
Status: assigned → closed

Removed in [1106].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christopher Lenz.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christopher Lenz to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.