Format error in web admin Plugins listing

[dmcr@…]

The web admin listing of plugins has a formatting error: The triangle character that points to the side or down (depending on whether the plugin listing is collapsed or not) is overlaid on top of the first character of the plugin name when using IE 8 as of version 0.12.1. See attachment.

This was not a problem when using IE 8 with Trac-0.12dev_r9810, nor is it a problem when using Firefox 3.0.19 with Trac-0.12.1.

Dennis

[dmcr@…]

Views of web admin Plugins listing using IE and Firefox

[Remy Blank]

Screenshot of Firefox

[Remy Blank]

Screenshot of IE8

[Remy Blank]

This probably requires a bit of CSS tweaking.

[Christian Boos]

I just tested - this seems to be a browser cache issue. In IE8, try CTRL+R (to be really sure, go in developer panel <F12> then Cache / Clear browser cache).

[Christian Boos]

checking with current trunk, using IE9 in IE8 mode

[dmcr@…]

Grrr! I hate these browser problems. Well, I tried what you suggested, Christian, including F12, etc, but it made no difference. I then closed all IE windows and tried again (also clearing the cache again), but no joy.

I am running Windows XP SP 3, FWIW.

Dennis

[Jun Omae]

The problem happens with IE7 and IE7 compatibility view for IE8. This seems A negative margin in admin.css doesn't work with the browsers.

.plugin > h3 a { margin-left: -16px; }

The following patch has tested with IE7, IE7 compatibility view IE8, Firefox 3.6, Firefox 4.0 beta and Chrome 8.0 on Windows XP. Could you test the patch with the other browsers?

trac/htdocs/css/admin.css

@@ -49 +49 @@
  padding: 2px .5em;
  text-align: left;
 }
-.plugin > h3 { margin: .5em 0; padding-left: 16px; color: #bb0000; }
-.plugin > h3 a { margin-left: -16px; }
+.plugin > .foldable { margin: .5em 0; color: #bb0000; }
 .plugin .buttons { margin-top: 0; text-align: right; }
 .plugin .uninstall { margin-top: -2.6em; padding: 0; }
 .plugin .summary, .plugin .info { padding-left: 16px; color: #999; font-size: 80%; }
@@ -60 +59 @@
 .plugin .info dd { padding: 0; margin: 0; }
 .plugin .listing { width: 100%; }
 .plugin .listing td { background: #fff; }
-.plugin .listing .foldable :link,
-.plugin .listing .foldable :visited { margin-left: -16px; }
 .trac-heading { margin: 0; }
 .trac-name { font-family: monospace; }
 .trac-toggler { color: #000; font-weight: normal; }
 .trac-toggler :link, .trac-toggler :visited,
 .trac-toggler :link:hover, .trac-toggler :visited:hover { border: none; padding: 0; }
 .trac-module .trac-heading { padding-left: 16px; color: #888; }
+.trac-module .trac-heading.foldable { text-indent: -16px }
 .trac-module > div { margin-left: 1em; }
-.trac-component .trac-heading { margin-left: 2em; padding-left: 16px; }
+.trac-component .trac-heading { margin-left: 2em; padding-left: 16px }
+.trac-component .trac-heading.foldable { text-indent: -16px }
 .trac-component > div { margin-left: 3em; }
 .trac-summary { color: #888; }
 table.trac-pluglist td { padding-left: 1em; }

[Remy Blank]

Works perfect on every browser I could lay a hand on (Firefox 3.6, Opera 11.0, Chromium 6.0.470.0 on Linux, IE8 and IE8 in IE7 mode on Windows 7). Please apply.

[Jun Omae]

Thanks for the testing, Remy! Applied in [10453].

[dmcr@…]

Thanks jomae!

Works great for me as well.

Dennis