Edgewall Software
Modify

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#9963 closed defect (fixed)

Format error in web admin Plugins listing

Reported by: dmcr@… Owned by: Jun Omae
Priority: normal Milestone: 0.12.2
Component: admin/web Version: 0.12.1
Severity: normal Keywords: bitesized
Cc:
Release Notes:
API Changes:

Description

The web admin listing of plugins has a formatting error: The triangle character that points to the side or down (depending on whether the plugin listing is collapsed or not) is overlaid on top of the first character of the plugin name when using IE 8 as of version 0.12.1. See attachment.

This was not a problem when using IE 8 with Trac-0.12dev_r9810, nor is it a problem when using Firefox 3.0.19 with Trac-0.12.1.

Dennis

Attachments (4)

TracWebAdminPlugins.doc (207.0 KB ) - added by dmcr@… 8 years ago.
Views of web admin Plugins listing using IE and Firefox
TracWebAdminPlugins-FF.png (61.0 KB ) - added by Remy Blank 8 years ago.
Screenshot of Firefox
TracWebAdminPlugins-IE8.png (83.2 KB ) - added by Remy Blank 8 years ago.
Screenshot of IE8
admin-plugins-IE8-mode.png (37.1 KB ) - added by Christian Boos 8 years ago.
checking with current trunk, using IE9 in IE8 mode

Download all attachments as: .zip

Change History (12)

Changed 8 years ago by dmcr@…

Attachment: TracWebAdminPlugins.doc added

Views of web admin Plugins listing using IE and Firefox

Changed 8 years ago by Remy Blank

Attachment: TracWebAdminPlugins-FF.png added

Screenshot of Firefox

Changed 8 years ago by Remy Blank

Attachment: TracWebAdminPlugins-IE8.png added

Screenshot of IE8

comment:1 Changed 8 years ago by Remy Blank

Keywords: bitesized added
Milestone: next-minor-0.12.x

This probably requires a bit of CSS tweaking.

comment:2 Changed 8 years ago by Christian Boos

I just tested - this seems to be a browser cache issue. In IE8, try CTRL+R (to be really sure, go in developer panel <F12> then Cache / Clear browser cache).

Changed 8 years ago by Christian Boos

Attachment: admin-plugins-IE8-mode.png added

checking with current trunk, using IE9 in IE8 mode

comment:3 Changed 8 years ago by dmcr@…

Grrr! I hate these browser problems. Well, I tried what you suggested, Christian, including F12, etc, but it made no difference. I then closed all IE windows and tried again (also clearing the cache again), but no joy.

I am running Windows XP SP 3, FWIW.

Dennis

comment:4 Changed 8 years ago by Jun Omae

The problem happens with IE7 and IE7 compatibility view for IE8. This seems A negative margin in admin.css doesn't work with the browsers.

.plugin > h3 a { margin-left: -16px; }

The following patch has tested with IE7, IE7 compatibility view IE8, Firefox 3.6, Firefox 4.0 beta and Chrome 8.0 on Windows XP. Could you test the patch with the other browsers?

  • trac/htdocs/css/admin.css

     
    4949 padding: 2px .5em;
    5050 text-align: left;
    5151}
    52 .plugin > h3 { margin: .5em 0; padding-left: 16px; color: #bb0000; }
    53 .plugin > h3 a { margin-left: -16px; }
     52.plugin > .foldable { margin: .5em 0; color: #bb0000; }
    5453.plugin .buttons { margin-top: 0; text-align: right; }
    5554.plugin .uninstall { margin-top: -2.6em; padding: 0; }
    5655.plugin .summary, .plugin .info { padding-left: 16px; color: #999; font-size: 80%; }
     
    6059.plugin .info dd { padding: 0; margin: 0; }
    6160.plugin .listing { width: 100%; }
    6261.plugin .listing td { background: #fff; }
    63 .plugin .listing .foldable :link,
    64 .plugin .listing .foldable :visited { margin-left: -16px; }
    6562.trac-heading { margin: 0; }
    6663.trac-name { font-family: monospace; }
    6764.trac-toggler { color: #000; font-weight: normal; }
    6865.trac-toggler :link, .trac-toggler :visited,
    6966.trac-toggler :link:hover, .trac-toggler :visited:hover { border: none; padding: 0; }
    7067.trac-module .trac-heading { padding-left: 16px; color: #888; }
     68.trac-module .trac-heading.foldable { text-indent: -16px }
    7169.trac-module > div { margin-left: 1em; }
    72 .trac-component .trac-heading { margin-left: 2em; padding-left: 16px; }
     70.trac-component .trac-heading { margin-left: 2em; padding-left: 16px }
     71.trac-component .trac-heading.foldable { text-indent: -16px }
    7372.trac-component > div { margin-left: 3em; }
    7473.trac-summary { color: #888; }
    7574table.trac-pluglist td { padding-left: 1em; }

comment:5 Changed 8 years ago by Remy Blank

Works perfect on every browser I could lay a hand on (Firefox 3.6, Opera 11.0, Chromium 6.0.470.0 on Linux, IE8 and IE8 in IE7 mode on Windows 7). Please apply.

comment:6 Changed 8 years ago by Jun Omae

Milestone: next-minor-0.12.x0.12.2
Resolution: fixed
Status: newclosed

Thanks for the testing, Remy! Applied in [10453].

comment:7 Changed 8 years ago by Jun Omae

Owner: set to Jun Omae

comment:8 in reply to:  7 Changed 8 years ago by dmcr@…

Thanks jomae!

Works great for me as well.

Dennis

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted.
to The owner will be changed from Jun Omae to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.